harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rana Dasgupta" <rdasg...@gmail.com>
Subject Re: [drlvm] New regression: java.lang.ClassGenericsTest4
Date Wed, 15 Nov 2006 18:37:56 GMT
I think that a problem with the junit tests is that some failures spit out
to the console, but show up in the test run results as passed. I find this
very confusing. So unless you are watching all the time, you can miss them.

On 11/15/06, Alexei Fedotov <alexei.fedotov@gmail.com> wrote:
>
> Guys,
>
> This is a good discussion, and let me praise Alexey for the wonderful fix.
>
> I'm a bit concerned about our accepptance checks. How this could be
> that regression was missed by a committer and an engineer durring
> acceptance test runs?
>
> Bug comments showed that Gregory ran the tests before a commit. Do
> tests report such problems clearly?
>
> Thanks!
>
>
>
> On 11/15/06, Pavel Afremov <pavel.n.afremov@gmail.com> wrote:
> > Oh. It's cool fix for my stupid bug.
> >
> >
> >
> > Thanks for Alexey very much.
> >
> > Pavel Afremov.
> >
> >
> > On 11/15/06, Alexey Varlamov <alexey.v.varlamov@gmail.com> wrote:
> > >
> > > Pardon for my English - a bit sleepy already...
> > >
> > > 2006/11/15, Alexey Varlamov <alexey.v.varlamov@gmail.com>:
> > > > Err, what I found is really trivial bug. But it took quite a few
> time
> > > > to discover - seems today was not my day :(
> > > >
> > > > Index: vm/vmcore/src/exception/exceptions_impl.cpp
> > > > ===============================================================
> > > > --- vm/vmcore/src/exception/exceptions_impl.cpp (revision 475132)
> > > > +++ vm/vmcore/src/exception/exceptions_impl.cpp (working copy)
> > > > @@ -281,7 +281,7 @@
> > > >
> > > >         if (NULL != exception->exc_cause) {
> > > >             tmn_suspend_disable_recursive();
> > > > -            jthrowable exc_cause = oh_allocate_local_handle();
> > > > +            exc_cause = oh_allocate_local_handle();
> > > >             exc_cause->object = exception->exc_cause;
> > > >             tmn_suspend_enable_recursive();
> > > >         }
> > > >
> > > >
> > > > OK, we definitely need a regression test for this.
> > > >
> > > > 2006/11/15, Gregory Shimansky <gshimansky@gmail.com>:
> > > > > Alexey Varlamov wrote:
> > > > > > 2006/11/15, Alexey Varlamov <alexey.v.varlamov@gmail.com>:
> > > > > >> 2006/11/15, Gregory Shimansky <gshimansky@gmail.com>:
> > > > > >> > Alexey Varlamov wrote:
> > > > > >> > > The guilty change is the following, which effectively
turns
> on
> > > > > >> > > VM_LAZY_EXCEPTION support in exceptions_impl.cpp:
> > > > > >> >
> > > > > >> > Well this is a patch from HARMONY-2018 which doesn't
hide the
> > > fact that
> > > > > >> > it enables lazy exceptions. Why shouldn't we enable
them?
> > > > > >
> > > > > > Gregory,
> > > > > >
> > > > > > I've just re-read my posts and couldn't find anything critique
> or
> > > > > > offending - please don't take regressions too personal. I'm
sure
> we
> > > > > > will be able to fix this one quite soon.
> > > > >
> > > > > I wasn't offended in any way. I was just thinking that you know
> some
> > > > > secret knowledge that lazy exceptions do not work and thus
> enabling
> > > them
> > > > > is wrong.
> > > > >
> > > > > --
> > > > > Gregory
> > > > >
> > > > >
> > > >
> > >
> >
> >
>
>
> --
> Thank you,
> Alexei
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message