harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geir Magnusson Jr." <g...@pobox.com>
Subject Re: svn commit: r479802 - /harmony/enhanced/drlvm/trunk/vm/vmcore/src/util/win/ia32/nt_exception_filter.cpp
Date Tue, 28 Nov 2006 15:42:34 GMT


Gregory Shimansky wrote:
> Gregory Shimansky wrote:
>>>> 2) It dropped support for "vm.assert_dialog" switch completely, which
>>>> is proved to be quite useful for various kinds of automated testing.
>>>> We even discussed recently that launcher lacks similar feature, and I
>>>> anticipate other developers will raise complains soon.
>>>
>>> Despite the fact that "vm.assert_dialog" check was removed, the support
>>> is still there: "vm.assert_dialog" controls the behaviour of the default
>>> handler.
>>>
>>> However, you are right that now the overall behaviour is determined
>>> by the launcher, so we need to change launcher correspondingly.
>>
>> Shall we agree that launcher should parse and handle this property? 
>> The name doesn't look very good to me (Geir will surely ask to change 
>> it).
>>
>> What about vm.windows.crt.debug.dialog ? AFAIK the property has no 
>> effect on linux, and the word "assert" doesn't reflect the purpose of 
>> this property too.
> 
> Now that I thought about it some more, what about controlling the 
> launcher default crash handler on all platforms? Specifying something 
> like -Dhy.launcher.crash.handler=false to disable crash handler 
> installation in launcher.

I like it, except for the preceeding "hy"... also, will this be used by 
any part of the system other than the launcher?

geir

Mime
View raw message