harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Ellison <t.p.elli...@gmail.com>
Subject Re: [alert] "ant rebuild" is broken
Date Tue, 28 Nov 2006 13:16:17 GMT
Mikhail Loenko wrote:
> how about this:
> 
> @@ -108,7 +108,7 @@
>     <!-- =================================
>           target: -compile
>          ================================= -->
> -    <target name="-compile" depends="-prepare-depends">
> +    <target name="-compile" depends="-prepare-depends, -layout">
> @@ -168,10 +167,19 @@
>             <src path="modules/x-net/src/main/java/" />
> 
>             <classpath>
> -                <fileset dir="${depends.jars}">
> +                <fileset dir="${hy.jdk}/jre/lib/boot">
>                     <include name="**/*.jar" />
>                 </fileset>
> 
> 
> We do copying first. As a result we don't have to mantain one more list

Yep, that will fix it right.

Aesthetically it would be good to get rid of this fileset from -layout:
  ...
  <fileset dir="${depends.jars}">
    <patternset includes="*.jar" />
    <patternset includes="xerces_2.8.0/*.jar" />
    <patternset includes="xalan-j_2.7.0/*.jar" />
    <patternset includes="icu4j_3.4.4/*.jar" />
    <patternset includes="mx4j_3.0.1/*.jar" />
    <patternset includes="yoko_M1-20061027/*.jar" />
    <patternset includes="bcel-5.2/*.jar" />
  </fileset>
  ...

and make it a refid, defined in the depends file, so updates to the
dependencies are localized.

Regards,
Tim

-- 

Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.

Mime
View raw message