harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geir Magnusson Jr." <g...@pobox.com>
Subject Re: svn commit: r479181 - /harmony/enhanced/drlvm/trunk/vm/vmcore/src/class_support/classloader.cpp
Date Sun, 26 Nov 2006 00:30:44 GMT
1) Why add the SuspendDisabledChecker if not using it?

2) exactly where did you add the assertion?  :)


gshimansky@apache.org wrote:
> Author: gshimansky
> Date: Sat Nov 25 11:59:38 2006
> New Revision: 479181
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=479181
> Log:
> Fixed 32-bitness in classloader tracing. Added assertion before using a raw heap object
pointer
> 
> 
> Modified:
>     harmony/enhanced/drlvm/trunk/vm/vmcore/src/class_support/classloader.cpp
> 
> Modified: harmony/enhanced/drlvm/trunk/vm/vmcore/src/class_support/classloader.cpp
> URL: http://svn.apache.org/viewvc/harmony/enhanced/drlvm/trunk/vm/vmcore/src/class_support/classloader.cpp?view=diff&rev=479181&r1=479180&r2=479181
> ==============================================================================
> --- harmony/enhanced/drlvm/trunk/vm/vmcore/src/class_support/classloader.cpp (original)
> +++ harmony/enhanced/drlvm/trunk/vm/vmcore/src/class_support/classloader.cpp Sat Nov
25 11:59:38 2006
> @@ -589,11 +589,13 @@
>  
>  ClassLoader* ClassLoader::AddClassLoader( ManagedObject* loader )
>  {
> +    SuspendDisabledChecker sdc;
> +
>      LMAutoUnlock aulock( &(ClassLoader::m_tableLock) );
>      ClassLoader* cl = new UserDefinedClassLoader();
>      TRACE2("classloader.unloading.add", "Adding class loader "
>          << cl << " (" << loader << " : "
> -        << ((VTable*)(*(unsigned**)(loader)))->clss->get_name()->bytes
<< ")");
> +        << loader->vt()->clss->get_name()->bytes << ")");
>      cl->Initialize( loader );
>      if( m_capacity <= m_nextEntry )
>          ReallocateTable( m_capacity?(2*m_capacity):32 );
> 
> 

Mime
View raw message