harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geir Magnusson Jr." <g...@pobox.com>
Subject Re: [testing] test exclude list: can't we have incremental exclusions?
Date Thu, 23 Nov 2006 18:02:33 GMT
And while you're at it, how about making kind-and-gentle support for 
local excludes such that I can have a file

     exclude.local

which is my local exclusion list that

a) will be svn-ignored and

b) doesn't have to be there - so if a developer hasn't created the file, 
the build just keeps going...  I *think* that not having the file for an 
<excludesfile> entry will let the build keep going, but I'm not sure.

geir


Geir Magnusson Jr. wrote:
> That works for me.  It will only increase the number of files if 
> platforms have bugs, but it will make for easier maintenance.
> 
> We'll do the same in DRLVM too.
> 
> geir
> 
> Ivanov, Alexey A wrote:
>> Hi everyone,
>>
>> Recently test exclude lists were removed from build.xml of the 
>> corresponding module, and there were added *six* files with excluded 
>> tests. These files contain almost the same list of files. The lists 
>> are identical for swing module. I found 2 differences for awt module 
>> (there are still about 50 files names listed in every of the exclude 
>> lists).
>>
>> Why can't we use one 'exclude.all' file to exclude tests which fail on 
>> every platform? It's an obvious optimization.
>> I've tested the approach of using several exclude list files on 
>> build.xml of swing module. It works just fine.
>>
>> Your comments?
>>
>> Regards,
>> Alexey.
>>
>>
>> ----- build.xml patch --------
>> Index: build.xml
>> ===================================================================
>> --- build.xml   (revision 478584)
>> +++ build.xml   (working copy)
>> @@ -186,6 +186,7 @@
>>
>>                  <fileset dir="${hy.swing.src.test.api}/java/common">
>>                      <include name="**/*Test*.java"/>
>> +                       <excludesfile name="./make/exclude.all" />
>>                      <excludesfile name="${exclude.file}" />
>>                  </fileset>
>>              </batchtest>
>> ------------------------------
>>
>>
>> -- 
>> Alexey A. Ivanov
>> Intel Enterprise Solutions Software Division

Mime
View raw message