harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geir Magnusson Jr." <g...@pobox.com>
Subject Re: [drlvm][threading] Should hythread_monitor_init() aquire the monitor?
Date Thu, 16 Nov 2006 14:52:08 GMT
Yes - that's why I was poking him to see the patch.  I was going to 
suggest something very similar.

geir


Gregory Shimansky wrote:
> Evgueni Brevnov wrote:
>> You can look at the change here
>> http://issues.apache.org/jira/browse/HARMONY-2203
> 
> Could someone who knowns classlib native code internals better than me 
> comment on this JIRA? I've added my comment from the general POV.
> 
> I would change the loop to detect only signal interruption like
> 
> while (sem_wait(&wakeUpASynchReporter) == -1 && errno == EINTR);
> 
> Other than that I agree with the patch. I someone does not know, every 
> step in gdb also interrupts sem_wait calls, so such loops are a common 
> practice when using semaphores.
> 
> If someone knows classlib internal logic with this asynchronous handlers 
> stuff please write your opinion.
> 

Mime
View raw message