harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geir Magnusson Jr." <g...@pobox.com>
Subject Re: [drlvm] [testing] Excluding commit tests until the problem is fixed
Date Wed, 15 Nov 2006 19:59:24 GMT
I like this approach.

+1

(it's exactly how I would have done it. :)

Vladimir Ivanov wrote:
> As part of solution for this issue the
> *HARMONY-2197*<http://issues.apache.org/jira/browse/HARMONY-2197> was
> created.
> 
> I suggest using the separate exclude list for each platform. I hope in this
> case the test enabling for the different platforms will be easy. Please,
> look at it.
> 
> Any comments are welcome :)
> 
> 
> 
> Thanks, Vladimir
> 
> 
> On 11/15/06, Alexei Fedotov <alexei.fedotov@gmail.com> wrote:
>>
>> Pavel, you are correct. Rana, sorry for confusion. Both issues block
>> passing class library unit tests.
>>
>> http://issues.apache.org/jira/browse/HARMONY-2070 [drlvm][thread]
>> Unhandled exception in java.exe while java.util.jar module tests
>> execution
>>
>> http://issues.apache.org/jira/browse/HARMONY-2073 [drlvm][unit]
>> org.apache.harmony.beans.tests.java.beans.PersistenceDelegateTest
>>
>> I've used a debugger and caught an assert in
>> exn_raise_by_name_internal for the second one. The first one contains
>> three diffrent issues, and I cannot say where exactly the problem is.
>>
>> On 11/15/06, Pavel Afremov < pavel.n.afremov@gmail.com> wrote:
>> > As I understand Alexey means HARMONY-2073, but not HARMONY-2070.
>> >
>> > Alexei, is it correct? If not, could you clarify the point about
>> > exn_raise_by_name_internal in your initial letter, please?
>> >
>> >
>> > Pavel Afremov.
>> >
>> >
>> > On 11/8/06, Rana Dasgupta <rdasgupt@gmail.com> wrote:
>> > >
>> > > OK thanks Pavel, I'll try the patch today.
>> > >
>> > > Rana
>> > >
>> > >
>> > > On 11/8/06, Pavel Afremov <pavel.n.afremov@gmail.com> wrote:
>> > > >
>> > > > Hi Rana.
>> > > >
>> > > >
>> > > >
>> > > > I extend guard region as work around. It's only one way, which 
>> "fix"
>> SOE
>> > > > on
>> > > > my SuSE Linux, without potential regression of your fix. On my 
>> Linux
>>
>> > > > machine
>> > > > violation access signals happen one page before protected page on
>> the
>> > > > stack.
>> > > > It's it.
>> > > >
>> > > >
>> > > >
>> > > > I ran all tests, and everything was OK. But strange misprint was
>> fount
>> > > in
>> > > > the new test.
>> > > >
>> > > > So I attach new fixed patch.
>> > > >
>> > > >
>> > > >
>> > > > Pavel Afremov.
>> > > >
>> > > >
>> > > > On 11/8/06, Rana Dasgupta <rdasgupt@gmail.com> wrote:
>> > > > >
>> > > > > Though I tried several times, I could not repro 2070 or Alexey's
>> > > > specific
>> > > > > problems. The test attached to 2018 repros, and that I think
is
>> > > enough.
>> > > > >
>> > > > > Pavel,
>> > > > >   1. The patch looks good, but I could not apply and try it since
>> my
>> > > > Linux
>> > > > > box is down.
>> > > > >   2. Did you run all tests ( smoke, cuint, kernel, and 
>> classlib )?
>>
>> > > Since
>> > > > > this fully turns on lazy exceptions, we need to ensure that all
>> tests
>> > > > > pass,
>> > > > > or at least have identical behaviour before and after the pacth.
>> > > > >   3. Adding a finalizer based stack test to smoke is a good idea.
>> > > > >   4. On Linux you extend the guard region up ( or down whatever
)
>> by a
>> > > > > page. Did you find a good reason for it, or is this just being
>> > > careful?
>> > > > >
>> > > > > Rana
>> > > > >
>> > > > >
>> > > > >
>> > > > >
>> > > > > On 11/7/06, Pavel Afremov < pavel.n.afremov@gmail.com>
wrote:
>> > > > > >
>> > > > > > Rana,
>> > > > > >
>> > > > > > Everything is correct in you description, but it looks like

>> that
>> *
>> > > > > > HARMONY-2018* <
>> https://issues.apache.org/jira/browse/HARMONY-2018>
>> > > > > should
>> > > > > > fix described bug. I think Alexei will have a chance to
check
>> it.
>> > > > > >
>> > > > > >
>> > > > > >
>> > > > > > Thank you.
>> > > > > >
>> > > > > > Pavel Afremov.
>> > > > > >
>> > > > > >
>> > > > > >
>> > > > >
>> > > > >
>> > > >
>> > > >
>> > >
>> > >
>> >
>> >
>>
>>
>> -- 
>> Thank you,
>> Alexei
>>
> 

Mime
View raw message