harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nathan Beyer" <nbe...@gmail.com>
Subject Re: [classlib][swing] test code changes
Date Mon, 27 Nov 2006 01:04:15 GMT
On 11/26/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
>
>
> Nathan Beyer wrote:
> > I made some changes to the swing module's test bits at revision 479469
> > and wanted to pass it by the mailing list.
> >
> > I copied the "javax.swing.SwingTestCase" and
> > "javax.swing.BaseSwingTestCase" classes from 'support' to the 'swing'
> > module. I recall a previous discussion about this, but let me know if
> > this isn't good. I'll delete the classes from 'support' later.
> >
> > To get this to work, I also updated the build.xml in 'swing'. Instead
> > of running all tests that match "**/*Test*.java", I changed it to
> > match "**/*Test.java" so that these two classes wouldn't be picked up.
>
> Why wouldn't you simply rename them?

We could, but just so everyone knows, combined these two classes are
used as the base class of essentially every test in the swing module.
Also, I'm not sure what would be a better name, as these abstract
classes extend TestCase and add "swing" features.

-Nathan
>
> geir
>
> >
> > -Nathan
>

Mime
View raw message