harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nathan Beyer" <nbe...@gmail.com>
Subject Re: [classlib][luni]serialize a non pulbic class
Date Thu, 23 Nov 2006 15:53:14 GMT
Note, the returned 'environment' is a Map type, so it's not
Serializable, so Alexey's argument is sound.

On 11/23/06, Tony Wu <wuyuehao@gmail.com> wrote:
> hmm...sounds resonable, I'd like to leave it as is if no customer
> report that. Thanks Alexey.
>
> On 11/23/06, Alexey Varlamov <alexey.v.varlamov@gmail.com> wrote:
> > I do not follow why we need serialization compatiblity here?
> > The j.l.Builder itself is not serializable, nor a Process
> > implementation for obvious reason - I don't think we should care about
> > env either.
> >
> > --
> > Alexey
> >
> > 2006/11/23, Richard <richard.liangyx@gmail.com>:
> > > Tony Wu wrote:
> > > > I generated the golden file by RI and got the testcase[1] below failed
> > > > on Harmony.
> > > > In general, we should implement a class whose name/package is
> > > > completely same as RI for serialization compatiblity, but the
> > > > customized Map  is not a public class.(i.e. I'm not able get the class
> > > > name from spec.) Is it proper to print the name by getClass.getName()
> > > > and follow RI here?
> > > >
> > > > [1]
> > > >  public void testSerializationCompatibility() throws Exception {
> > > >        ProcessBuilder pb = new ProcessBuilder("Arg1", "Arg2", "Arg3");
> > > >        Map<String, String> env = pb.environment();
> > > >        SerializationTest.verifyGolden(this, env);
> > > >    }
> > > >
> > > >
> > > >
> > > IMHO, we shall use the same class name.
> > >
> > > --
> > > Richard Liang
> > > China Development Lab, IBM
> > >
> > >
> >
>
>
> --
> Tony Wu
> China Software Development Lab, IBM
>

Mime
View raw message