harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konovalova, Svetlana" <svetlana.konoval...@intel.com>
Subject RE: [doc] site.css
Date Tue, 21 Nov 2006 07:59:51 GMT
Alexey,

I've looked through the patch and it seems to be just fine.
It breaks nothing :)

Best regards,
Sveta

-----Original Message-----
From: Ivanov, Alexey A [mailto:alexey.a.ivanov@intel.com] 
Sent: Monday, November 20, 2006 6:12 PM
To: harmony-dev@incubator.apache.org; geir@pobox.com
Subject: RE: [doc] site.css

Hi all,

I've prepared a patch where converted all tabs to spaces.
See https://issues.apache.org/jira/browse/HARMONY-2244

Almost each line is modified.


Regards,
--
Alexey A. Ivanov
Intel Enterprise Solutions Software Division

>-----Original Message-----
>From: Geir Magnusson Jr. [mailto:geir@pobox.com]
>Sent: Tuesday, November 14, 2006 8:27 PM
>To: harmony-dev@incubator.apache.org
>Subject: Re: [doc] site.css
>
>
>
>Ivanov, Alexey A wrote:
>> Hi all,
>>
>> I've updated formatting of definition lists <DL> on site:
>https://issues.apache.org/jira/browse/HARMONY-2173
>>
>> The new formatting looks more natural to me; the screenshots can be
found
>in the JIRA issue.
>
>yes, that looks better.
>
>>
>>
>> When editing site.css I faced that there are many different styles of
>indentation used:
>>     * Some statements are indented using tabs,
>>     * Some -- using spaces,
>>     * And a mixture of tabs and space, in the worse case.
>>
>> There are also inconsistencies in formatting of rules, and trailing
>white-space.
>>
>> Let's agree on using either tabs or spaces for indentation of CSS
>statements. If they are different, it causes inconveniences when
creating
>patches because some lines look changed while nothing was modified
there.
>>
>> I have no strong opinion on which one to use here. But let it be one:
>either tabs or spaces.
>>
>> What do you think about it?
>
>I think that since I don't have the first clue about css, and don't
>intend do it, you can choose :)
>
>That said, I think that spaces are the right way - it's consistent w/
>our other source formatting policies.
>
>geir
>
>
>>
>>
>> Thank you in advance,
>> --
>> Alexey A. Ivanov
>> Intel Enterprise Solutions Software Division
>>

Mime
View raw message