harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Volosyuk" <ivan.volos...@gmail.com>
Subject Re: [jira] Commented: (HARMONY-2100) [classlib] java.awt.color.ICC_ProfileRTest fails
Date Fri, 17 Nov 2006 17:01:53 GMT
Sergey,

It is ok to have not thread safe code in AWT implementation which can
work incorrectly in some cases. It is not ok (IMHO) if the incorrect
work leads to VM crash. It can be problem as a security hole.

--
Best regards,
Ivan

On 11/17/06, Sergey Soldatov (JIRA) <jira@apache.org> wrote:
>     [ http://issues.apache.org/jira/browse/HARMONY-2100?page=comments#action_12450683
]
>
> Sergey Soldatov commented on HARMONY-2100:
> ------------------------------------------
>
> I'm not sure there is any reason to do it, since this functionality is not supposed to
be run from several threads. AWT itself is not threadsafe and documentation recommends to
make all AWT calls from event dispatch thread. I would keep it as is.
>
> > [classlib] java.awt.color.ICC_ProfileRTest fails
> > ------------------------------------------------
> >
> >                 Key: HARMONY-2100
> >                 URL: http://issues.apache.org/jira/browse/HARMONY-2100
> >             Project: Harmony
> >          Issue Type: Bug
> >          Components: Classlib
> >         Environment: SUSE 9
> > debug DRLVM
> >            Reporter: Alexey Varlamov
> >         Assigned To: Alexey Varlamov
> >            Priority: Minor
> >         Attachments: harmony-2100.patch, quick_fix.diff
> >
> >
> > The java.awt.color.ICC_ProfileRTest passes on JITs and fails on interpreter:
> > junit.framework.AssertionFailedError: IllegalArgumentExceptione expected
> > at java.awt.color.ICC_ProfileRTest.testGetInstance(ICC_ProfileRTest.java:38)
> > at java.lang.reflect.VMReflection.invokeMethod(VMReflection.java)
> > To reproduce:
> > edit $vm/build/lnx_ia32_gcc_debug/deploy/jre/bin/default/harmonyvm.properties, add
"-Xint" line to it;
> > cd $classlib
> > ant -Dtest.jre.home=$vm/build/lnx_ia32_gcc_debug/deploy/jre test -Dtest.case=java.awt.color.ICC_ProfileRTest
-Dbuild.module=awt
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira

-- 
Ivan
Intel Enterprise Solutions Software Division

Mime
View raw message