Return-Path: Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org Received: (qmail 42491 invoked from network); 18 Oct 2006 10:06:14 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 18 Oct 2006 10:06:14 -0000 Received: (qmail 5032 invoked by uid 500); 18 Oct 2006 10:06:07 -0000 Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org Received: (qmail 4969 invoked by uid 500); 18 Oct 2006 10:06:06 -0000 Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-dev@incubator.apache.org Received: (qmail 4958 invoked by uid 99); 18 Oct 2006 10:06:06 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Oct 2006 03:06:06 -0700 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=DNS_FROM_RFC_ABUSE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of alexey.v.varlamov@gmail.com designates 66.249.82.225 as permitted sender) Received: from [66.249.82.225] (HELO wx-out-0506.google.com) (66.249.82.225) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Oct 2006 03:06:05 -0700 Received: by wx-out-0506.google.com with SMTP id t15so218236wxc for ; Wed, 18 Oct 2006 03:05:44 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=RtTJPf9rSadC5pIOiadE+Os1QD9f9hCoDxwGI7D/MGlYgR0UCNkmU66DYPMeaO+igXp/+ElG/PiZyiI+nEKV6pxgdRHKpLtsLw9qwTHbqhuN/KwcqY2oD8KX5oTvJsmn/XYRuf03LT3xRCDlnupPm/YXoWKBcghNWqNaMQ2SqII= Received: by 10.70.67.15 with SMTP id p15mr15739368wxa; Wed, 18 Oct 2006 03:05:44 -0700 (PDT) Received: by 10.70.23.14 with HTTP; Wed, 18 Oct 2006 03:05:44 -0700 (PDT) Message-ID: Date: Wed, 18 Oct 2006 17:05:44 +0700 From: "Alexey Varlamov" To: harmony-dev@incubator.apache.org Subject: Re: [classlib][swing] test failure: javax.swing.filechooser.FileSystemViewTest.testGetSystemTypeDescription In-Reply-To: <8E389A5F2FEABA4CB1DEC35A25CB39CE5E41A6@mssmsx411> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <8E389A5F2FEABA4CB1DEC35A25CB39CE5E41A6@mssmsx411> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [snip] > > > > >I agree we remove the locale dependent assertions temporarily. > > On the other hand, these assertions merely check that file corresponds to "File", and folder corresponds to "Folder" or "File Folder". > We can check that the return value is not null and is not empty string, at least temporarily. Yes, just perform this check more carefully. > > Later we can implement locale switching, if we want to. If we will want it ever. > > What do you think? > > Regards, > Alexey. > > > > > >Best regards, > >Richard > > > >> > >> Regards, > >> Alexey. > >> > >> P.S. See also related issue [2]: "j.s.filechooser.FileSystemViewTest > >prompts to insert disk into drive A:". > >> > >> > >> [1] https://issues.apache.org/jira/browse/HARMONY-1893 > >> [2] https://issues.apache.org/jira/browse/HARMONY-1892 > >> > >> > >> -- > >> Alexey A. Ivanov > >> Intel Middleware Product Division > >> > >> > >> >-----Original Message----- > >> >From: Richard Liang [mailto:richard.liangyx@gmail.com] > >> >Sent: Wednesday, October 11, 2006 12:06 PM > >> >To: harmony-dev@incubator.apache.org > >> >Subject: [classlib][swing] test failure: > >> >javax.swing.filechooser.FileSystemViewTest.testGetSystemTypeDescription > >> > > >> >Hello, > >> > > >> >The test fails "on Windows XP when the locale-setting is zh_CN. It's > >> >because that "view.getSystemTypeDescription(file)" returns Chinese > >> >words "文件" instead of "File". > >> > > >> >Could any one help to verify this issue? Thanks a lot. > >> > > >> >-- > >> >Richard Liang > >> >China Development Lab, IBM > >> > > >> >--------------------------------------------------------------------- > >> >Terms of use : http://incubator.apache.org/harmony/mailing.html > >> >To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > >> >For additional commands, e-mail: harmony-dev-help@incubator.apache.org > >> > >> --------------------------------------------------------------------- > >> Terms of use : http://incubator.apache.org/harmony/mailing.html > >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org > >> > >> > > > > > >-- > >Richard Liang > >China Development Lab, IBM > > > >--------------------------------------------------------------------- > >Terms of use : http://incubator.apache.org/harmony/mailing.html > >To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > >For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > -- > Alexey A. Ivanov > Intel Middleware Product Division > > --------------------------------------------------------------------- > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org For additional commands, e-mail: harmony-dev-help@incubator.apache.org