Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
DomainKey-Status: good
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=ApQJ7wkWX/AjDs1JR5FwjpBmfYTahGuwhGmSEQGB5jtG01hufBQpeOKsgqk6CfDmd64mh87Afgmz4A/hfwkKiQBbb+AWwx93PbOVUmJcGiY5npne+Z+v+Kd1JmrBfddc3F9rInwMai8zF30CnbkGUdTMT8m/A/t2OSHBhnKRdQU=
Message-ID: <f944d83d0610040313k39f5b9fere5ae71c762fbe630@mail.gmail.com>
Date: Wed, 4 Oct 2006 17:13:24 +0700
From: "Alexey Varlamov" <alexey.v.varlamov@gmail.com>
To: harmony-dev@incubator.apache.org
Subject: Re: [r451637] - Code cleanup - ... - Remove unnecessary comments
In-Reply-To: <3b3f27c60610031658l49fee490g5a5f80f60cd516c3@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <f944d83d0610030319s4f3967c7pee51a82dea2b8db@mail.gmail.com>
	 <3b3f27c60610031658l49fee490g5a5f80f60cd516c3@mail.gmail.com>

2006/10/4, Nathan Beyer <nbeyer@gmail.com>:
> If this is an event that should be logged, as the TODO indicated, then
> why not just print out the stack trace and be done with it? If this
> exception happens so often that you'd like it removed, then why would
> we want to log a warning message, which I would presume would print to
> the console just as frequently.

Logging and printing to console essentially differ in flexible
customization offered by the first approach. An application can have
no console after all.
We develop the common class library here, not an ordinary application
- so let's not assume it will be used in some particular way.

In this concrete case, stack trace is printed every time invalid input
data is supplied - and it is normal for a unit test to cover some
negative cases.
But seeing console jammed with that rubbish is quite confusing (for me
at least). OTOH, such info would be valuable for app developer - so
why not satisfy both?

>
> As for TODOs, in general I find TODOs never get done, especially
> trivial ones like this particular case.
Because we have more priority tasks to be done. We just haven't
reached that stage of completeness, when we can afford minor refining
and polishing. Never say never, you know :)

Please, announce ahead if you do such things in future.

--
Regards,
Alexey

>
> -Nathan
>
> On 10/3/06, Alexey Varlamov <alexey.v.varlamov@gmail.com> wrote:
> > Nathan,
> >
> > I've seen you dropped many TODOs in "- Code cleanup -" series of commits;
> > I'd like to know what reasoning was behind this? I think it's a bit
> > early to erase TODOs without appropriate consideration...
> >
> > In particular, could you please undo the following change, it produces
> > garbage messages during AUTH testing:
> >
> > modules/auth/src/main/java/common/org/apache/harmony/auth/login/DefaultConfigurationParser.java
> > ===========
> > @@ -216,12 +206,12 @@ public class DefaultConfigurationParser
> > try {
> > val = PolicyUtils.expand(st.sval, system);
> > } catch (Exception e) {
> > - //TODO: warning log
> > - }
> > + e.printStackTrace();
> > + }
> > }
> >
> > --
> > WBR,
> > Alexey
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org