Return-Path: Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org Received: (qmail 94986 invoked from network); 6 Oct 2006 06:55:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 6 Oct 2006 06:55:40 -0000 Received: (qmail 41137 invoked by uid 500); 6 Oct 2006 06:55:36 -0000 Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org Received: (qmail 41097 invoked by uid 500); 6 Oct 2006 06:55:36 -0000 Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-dev@incubator.apache.org Received: (qmail 41086 invoked by uid 99); 6 Oct 2006 06:55:36 -0000 Received: from idunn.apache.osuosl.org (HELO idunn.apache.osuosl.org) (140.211.166.84) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Oct 2006 23:55:36 -0700 Authentication-Results: idunn.apache.osuosl.org header.from=evgueni.brevnov@gmail.com; domainkeys=good X-ASF-Spam-Status: No, hits=0.5 required=5.0 tests=DNS_FROM_RFC_ABUSE DomainKey-Status: good X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 Received: from [66.249.82.230] ([66.249.82.230:58610] helo=wx-out-0506.google.com) by idunn.apache.osuosl.org (ecelerity 2.1.1.8 r(12930)) with ESMTP id C1/35-16439-5EDF5254 for ; Thu, 05 Oct 2006 23:55:34 -0700 Received: by wx-out-0506.google.com with SMTP id s13so832311wxc for ; Thu, 05 Oct 2006 23:55:30 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=n4/cMcVFsqWGHAnFNUiWYiIsTOuSrN8GKQofcvBxVZ9HJwvxZEWu+3/wZvpiazFOIT+sSM5RAS61OVDvsx6WAlWogXHKlLBXdjvhyxlkBRpdt7Y7nCQOUJXOX4b13QptQyo2lM7I31PzB4/I7VbyOutsdselb4jM2/d6GFB/u1g= Received: by 10.90.65.11 with SMTP id n11mr1433813aga; Thu, 05 Oct 2006 23:55:30 -0700 (PDT) Received: by 10.90.63.14 with HTTP; Thu, 5 Oct 2006 23:55:30 -0700 (PDT) Message-ID: Date: Fri, 6 Oct 2006 13:55:30 +0700 From: "Evgueni Brevnov" To: harmony-dev@incubator.apache.org, geir@pobox.com Subject: Re: [drlvm] too tired, need help In-Reply-To: <4525F8C1.5050109@pobox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <4525EB2E.6020301@pobox.com> <4dd1f3f00610052257w7fad9e8eq86d5111cab7d5ee5@mail.gmail.com> <4525F0BE.50507@pobox.com> <4525F3C3.6010902@pobox.com> <4525F60C.3030608@pobox.com> <4525F8C1.5050109@pobox.com> X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N I can't provide you with the fresh patch right now. I want to restrore cunit tests first. If it doesn't introduce many changes then go ahead and commit. It should be easy to merge then. Evgueni On 10/6/06, Geir Magnusson Jr. wrote: > And it would only introduce a few, as far as I can tell, as only jni.cpp > and vm_main.cpp actually include init.h, and therefore are the only > files that depend on that global > > geir > > Evgueni Brevnov wrote: > > Geir, > > > > Please don't do that until HARMONY-1582 integration. It can introduce > > many conflicts. > > > > Tnanks in advance. > > Evgueni > > > > On 10/6/06, Geir Magnusson Jr. wrote: > >> I got it - thanks to Pavel. > >> > >> There's an extern in init.h, and it's declared in vm_main.cpp. > >> > >> Would anyone mind if I renamed it something less innocuous like > >> > >> global_env > >> vm_global_env > >> > >> Something that gives the reader the hint that it's not a local var. > >> > >> geir > >> > >> > >> Geir Magnusson Jr. wrote: > >> > Thank you. > >> > > >> > How does the compiler know this when compiling jni.cpp? is there an > >> > extern defn somewhere? > >> > > >> > geir > >> > > >> > Pavel Rebriy wrote: > >> >> File vm/vmcore/src/init/vm_main.cpp, line 68. > >> >> > >> >> Global_Env env(m, properties); > >> >> > >> >> On 06/10/06, Geir Magnusson Jr. wrote: > >> >>> > >> >>> I know the type. The question is where is that variable "env" > >> declared > >> >>> and set? > >> >>> > >> >>> geir > >> >>> > >> >>> > >> >>> > >> >>> Weldon Washburn wrote: > >> >>> > The first parameter to create_vm() is of type Global_Env. > >> >>> > > >> >>> > Global_Env is defined in environment.h > >> >>> > > >> >>> > vm_init() in vm_init.cpp initializes a bunch of Globla_Env's > >> members. > >> >>> > > >> >>> > > >> >>> > > >> >>> > > >> >>> > On 10/5/06, Geir Magnusson Jr. wrote: > >> >>> >> > >> >>> >> I'm trying to trace through the boot sequence chasing some boot > >> >>> >> classpath property thing (luniglob sets it, and I can't figure > >> how it > >> >>> >> gets to us...), and I'm too tired, too dumb, or both to figure > >> this > >> >>> out. > >> >>> >> > >> >>> >> Launcher calls JNI_CreateJavaVM. In our > >> vmcore/src/jni/jni.cpp, we > >> >>> >> define it, and it is : > >> >>> >> > >> >>> >> VMEXPORT jint > >> >>> >> JNICALL JNI_CreateJavaVM(JavaVM **p_vm, JNIEnv **p_env, void > >> >>> *vm_args) > >> >>> { > >> >>> >> > >> >>> >> static int called = 0; > >> >>> >> > >> >>> >> init_log_system(); > >> >>> >> TRACE2("jni", "CreateJavaVM called"); > >> >>> >> if (called) { > >> >>> >> ASSERT(0, "Not implemented"); > >> >>> >> return JNI_ERR; > >> >>> >> } else { > >> >>> >> create_vm(&env, (JavaVMInitArgs *)vm_args); > >> >>> >> *p_env = &jni_env; > >> >>> >> *p_vm = jni_env.vm; > >> >>> >> return JNI_OK; > >> >>> >> } > >> >>> >> } > >> >>> >> > >> >>> >> For the life of me, I can't figure out where "env" is defined > >> or set. > >> >>> >> create_vm() uses it... > >> >>> >> > >> >>> >> Can anyone give me a hint? Eclipse's C++ plugin seems to be > >> useless > >> >>> >> here... > >> >>> >> > >> >>> >> geir > >> >>> >> > >> >>> >> > >> --------------------------------------------------------------------- > >> >>> >> Terms of use : http://incubator.apache.org/harmony/mailing.html > >> >>> >> To unsubscribe, e-mail: > >> harmony-dev-unsubscribe@incubator.apache.org > >> >>> >> For additional commands, e-mail: > >> >>> harmony-dev-help@incubator.apache.org > >> >>> >> > >> >>> >> > >> >>> > > >> >>> > > >> >>> > >> >>> --------------------------------------------------------------------- > >> >>> Terms of use : http://incubator.apache.org/harmony/mailing.html > >> >>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > >> >>> For additional commands, e-mail: > >> harmony-dev-help@incubator.apache.org > >> >>> > >> >>> > >> >> > >> >> > >> > > >> > --------------------------------------------------------------------- > >> > Terms of use : http://incubator.apache.org/harmony/mailing.html > >> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > >> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > >> > > >> > >> --------------------------------------------------------------------- > >> Terms of use : http://incubator.apache.org/harmony/mailing.html > >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org > >> > >> > > > > --------------------------------------------------------------------- > > Terms of use : http://incubator.apache.org/harmony/mailing.html > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > > > --------------------------------------------------------------------- > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org For additional commands, e-mail: harmony-dev-help@incubator.apache.org