Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Received-SPF: pass (herse.apache.org: domain of mike.fursov@gmail.com
 designates 66.249.92.174 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=oKHp0DN3QUsSjTyVkvtVs18tFkWyWkgK49SJoTVS7YcBd0qbd6jx3OeLXrx/2aV/NzKZhmfXUifjCLiIA9cexy96lUlAkD2IyInQ2jv7HvdZTUXBnwZ4zyKHoNn6DOz1Th7s/EOxmLTKoQtJnmGaOEauTRtczkuBuyd8l0wJNuI=
Message-ID: <bc79dd600610270542t48353eacyaec0c2618ca8a698@mail.gmail.com>
Date: Fri, 27 Oct 2006 19:42:54 +0700
From: "Mikhail Fursov" <mike.fursov@gmail.com>
To: harmony-dev@incubator.apache.org, geir@pobox.com
Subject: Re: [drlvm][jit] Internal testing framework for Jitrino.OPT compiler
In-Reply-To: <4541FA3C.6090902@pobox.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_42329_18453561.1161952974584"
References: <bc79dd600609210734w25701319v9a150f651d597168@mail.gmail.com>
	 <469bff730609220335g4969730aydc7a2042a7de94ec@mail.gmail.com>
	 <e4e7fdac0609220347o79f983a6g4632845a28c3821c@mail.gmail.com>
	 <bc79dd600609220509j48e59e4bra3db98dfe605e9a4@mail.gmail.com>
	 <e4e7fdac0609260625s1f455cc2w48b5b69ab7c07444@mail.gmail.com>
	 <bc79dd600609270738u297d7871pc6cd4565f47e8289@mail.gmail.com>
	 <e4e7fdac0610270339j2c249719l7529ce301bcfa057@mail.gmail.com>
	 <bc79dd600610270459g75f2c804nb9b5b9d0de8a3f1@mail.gmail.com>
	 <4541FA3C.6090902@pobox.com>

------=_Part_42329_18453561.1161952974584
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Geir,
I also thought about additional cmd-line param to compile and link
Jitrino.dll with tests. I hope we will have a lot of tests in future, so IMO
it's a good idea to separate it from default Jitrino build.
I'll try to provide this switch with the next patch and that could be a good
time to add framework into the trunk.

Another issue is how to run the tests. I added 'junit_integration' into the
patch - so we already have a solution.


On 10/27/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
>
> While you're at it, I'd like to get this patches in, but we probably
> need a new target for building, as running normally with this framework
> compiled in leads to problems.
>
> Can we find a way to make it a different build target, or at least a flag
>
>     -Dwith.jitrino.test.framework
>
> or something?
>
> (Apologies if you've already done that :)
>
> geir
>
> Mikhail Fursov wrote:
> > Thank you Ivan.
> > The problem you found with TestRegistry.cpp will be fixed with the next
> my
> > patch for Jitrino testing framework.
> > I'll check all of your tests this weekend and post comments.
> >
> > On 10/27/06, Ivan Kollegov <kollegov.ivan@gmail.com> wrote:
> >>
> >> Hi JIT developers.
> >>
> >> I've wrote 4 templates and about 20 tests to test Jitrino's internal
> >> algorithms. I put them all into JIRA-1586
> >>
> >> Also I've founded a problem with testing simplifier.cpp (test
> >> testSimplifyIf). The problem was in
> >>
> >> FlowGraph::foldBranch(ControlFlowGraph& fg, Node* block, BranchInst*
> >> br, bool isTaken)
> >>
> >> {
> >>     assert(br == block->getLastInst());
> >>     assert(block->getOutDegree() == 2);
> >>      fg.removeEdge(block->getOutEdge(isTaken ? Edge::Kind_False :
> >> Edge::Kind_True));
> >>      br->unlink();
> >> }
> >>
> >> The variable "block" can be null. This problem can be fixed with patch
> >> in JIRA-1986
> >>
> >> Also, I had problems with race condition with initializing of static
> >> section in TestRegistry* TestRegistry::getInstance(){
> >>
> >> Could you check the changes?
> >>
> >
> >
> >
>


-- 
Mikhail Fursov

------=_Part_42329_18453561.1161952974584--