Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Received-SPF: pass (asf.osuosl.org: domain of roberthurui@gmail.com designates
 64.233.162.206 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=Yo913cQSzbPySiWiPS1lL1YRD53GOEHw8YXUYCx3WkbTa+GOEeoj5BZBxsSA7ese/H9oQfPgX19bMV3f1/ZQYkvhNntd4arqnCvzTZgV6ODOHy3zIqgtbLTavaqlDDKMILlK1ksWsYszUATNNjQkVIONe/nxWh1RqRmsVifmHms=
Message-ID: <b6dc17480610110128g6f8d1a3as9ceadf425d3d9770@mail.gmail.com>
Date: Wed, 11 Oct 2006 16:28:31 +0800
From: "Rui Hu" <roberthurui@gmail.com>
To: harmony-dev@incubator.apache.org
Subject: Re: [classlib] [tests] Can anyone explain what these are for?
In-Reply-To: <ea7a13d60610102245h66ee6110o64bce5c6d0bc536d@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_19978_5672183.1160555311793"
References: <200610101837.k9AIbU4a018191@d06av02.portsmouth.uk.ibm.com>
	 <c3755b3a0610101243k6c2d1882p6fea030275b47b12@mail.gmail.com>
	 <3b3f27c60610101938v6ccd89d4i1418c03d2ab97b2d@mail.gmail.com>
	 <ea7a13d60610102058m7abbdf15j7c708d0cbc02df05@mail.gmail.com>
	 <3b3f27c60610102109m40778c8bwb4c0a012f20c3d6f@mail.gmail.com>
	 <ea7a13d60610102245h66ee6110o64bce5c6d0bc536d@mail.gmail.com>

------=_Part_19978_5672183.1160555311793
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

I've written a script to search all the statements like that:

#!/usr/bin/perl -w
use File::Find;
use DirHandle;
use strict;

my $dir = $ARGV[0] || die "need input a dir\n";
chomp $dir;
processDir($dir);

sub processDir {

my $folder = $_[0];

my $dh = DirHandle->new($folder) || die "can not open directiony: $!\n";

foreach my $f ($dh->read()) {
        next if ($f=~/^\.$|^\.\.$|^\..*$/);
        if (-d "$folder\/$f"){
                processDir("$folder\/$f");
        }
        if ($f=~/^.*Test\.java$/){
                processFile("$folder\/$f");
        }
}
}

sub processFile {
        my $f = $_[0];
        my $lineNum = 1;
  my $line="";
        open (MYFILE,"$f") || die "can not open file: $!\n";
        while ($line=<MYFILE>){
                chomp $line;
                if ($line=~/^\s*assertTrue.*true\s*\)\s*;\s*$/){
     print "$f:$lineNum\n";
                }
                $lineNum = $lineNum +1;
        }
}


And found 88 statements like that in current classlib, then record them in
[1].
We can check them.

[1].http://wiki.apache.org/harmony/Invalid_assertTrue


On 10/11/06, Richard Liang <richard.liangyx@gmail.com> wrote:
>
> On 10/11/06, Nathan Beyer <nbeyer@gmail.com> wrote:
> > Perhaps, but there are much better ways of determining that. From just
> > reading the test code to code coverage tools.
> >
> > From my analysis, these were part of the large test contribution and
> > indicated that there wasn't an explicit test for that method. In most
> > cases, there were tests for these methods, either in other classes or
> > in other methods of the class.
>
> Nathan, I agree ;-)
>
> >
> > -Nathan
> >
> > On 10/10/06, Richard Liang <richard.liangyx@gmail.com> wrote:
> > > On 10/11/06, Nathan Beyer <nbeyer@gmail.com> wrote:
> > > > I've seen a few and I've deleted any that I've come across. I would
> > > > say feel free to delete them too. I've also been deleting empty
> setup
> > > > and teardown methods too.
> > >
> > > Please do not simply delete them. Maybe that means we are lack of the
> > > test for some methods, for example "getInetAddress".
> > >
> > > >
> > > > -Nathan
> > > >
> > > > On 10/10/06, Alexey Petrenko <alexey.a.petrenko@gmail.com> wrote:
> > > > > These could be a result of copy/paste tests creation.
> > > > > And I'm curious why it was written for the first time. :)
> > > > >
> > > > > SY, Alexey
> > > > >
> > > > > 2006/10/10, Mark Hindess <mark.hindess@googlemail.com>:
> > > > > >
> > > > > > I've come across a couple of tests with things like:
> > > > > >
> > > > > >         public void test_getInetAddress() {
> > > > > >                 assertTrue("Used to test", true);
> > > > > >         }
> > > > > >
> > > > > > Can anyone explain why we have these?
> > > > > >
> > > > > > Regards,
> > > > > >  Mark.
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> ---------------------------------------------------------------------
> > > > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > > > To unsubscribe, e-mail:
> harmony-dev-unsubscribe@incubator.apache.org
> > > > > > For additional commands, e-mail:
> harmony-dev-help@incubator.apache.org
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Alexey A. Petrenko
> > > > > Intel Middleware Products Division
> > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > > To unsubscribe, e-mail:
> harmony-dev-unsubscribe@incubator.apache.org
> > > > > For additional commands, e-mail:
> harmony-dev-help@incubator.apache.org
> > > > >
> > > > >
> > > >
> > > >
> ---------------------------------------------------------------------
> > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail:
> harmony-dev-help@incubator.apache.org
> > > >
> > > >
> > >
> > >
> > > --
> > > Richard Liang
> > > China Development Lab, IBM
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> Richard Liang
> China Development Lab, IBM
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


-- 
Robert Hu
China Software Development Lab, IBM

------=_Part_19978_5672183.1160555311793--