Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Received-SPF: pass (herse.apache.org: domain of t.p.ellison@gmail.com
 designates 64.233.182.187 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding;
        b=Z4+DH8D17plj7iv8b8LY1ti7hSEf5p+9bct3tTX2CfEMJfdZoptnauNr9J63OueUZirSablWwFRJdNO51f9LAWeyt8KE9mMeBMH4Kuig8b8XZhRO1Rh63L1NYMGd4VUBRnBEySbQ0wATcQcQh/8GnVICkel0mgoI634qwz5/qlo=
Message-ID: <4545C1A3.3020705@gmail.com>
Date: Mon, 30 Oct 2006 09:10:59 +0000
From: Tim Ellison <t.p.ellison@gmail.com>
User-Agent: Thunderbird 1.5.0.7 (Windows/20060909)
MIME-Version: 1.0
To: harmony-dev@incubator.apache.org
Subject: Re: [classlib][IBMVME]the return value of java.exe
References: <211709bc0610291903i29eb7be2yd91e4a47dcd89933@mail.gmail.com>
	 <4545718E.5080208@gmail.com>
	 <e29119980610292056r368107b8t488bf359e920dd39@mail.gmail.com>
	 <e29119980610292114y317db02fs87d3a6bb53761395@mail.gmail.com>
	 <e29119980610292154i7a499b23p4b2b91e8c81ee4ab@mail.gmail.com>
 <e29119980610292235v29101c2fs99d9cf206cebb3d9@mail.gmail.com>
In-Reply-To: <e29119980610292235v29101c2fs99d9cf206cebb3d9@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit

Evgueni Brevnov wrote:
> BTW, here is two more interesting cases
> 
> 1) Throw uncaught exception in a new thread. Both RI and DRLVM give 0
> in that case.
> 2) Call System.exit(123) in a new thread. Both RI and DRLVM give 123.
> 
> Currently, DRLVM calls system _exit() at the end of System.exit().
> That's why DestroyJavaVM never returns. So the changes I proposed for
> the launcher do not help until DRLVM forcibly terminates the process.
> :-(
> 
> Does IBMVME uses system calls to stop the proccess? Does DestroyJavaVM
> returns?

You cannot kill the entire process when destroying the VM.  Apps that
embed the VM will have a nasty surprise.

Regards,
Tim

> On 10/30/06, Evgueni Brevnov <evgueni.brevnov@gmail.com> wrote:
>> It seems we need to fix the launcher... which is common part for both
>> DRLVM and IBVME. I see the problem in the following code sequence...
>>
>> <snip>
>>  (*jvm)->DetachCurrentThread(jvm);
>>  (*jvm)->DestroyJavaVM (jvm);
>> </snip>
>>
>> The current thread has an uncaught exception raised before it calls
>> DetachCurrentThread. This exception is printed out by default uncaught
>> exception handler which is called upon thread detaching. So after
>> DetachCurrentThread completes we have no exception anymore... Moreover
>> we can not play with DetachCurrentThread and DestroyJavaVM return code
>> since it should not depend on uncaught exceptions. So I think the fix
>> should look like the following:
>>
>> <snip>
>>   if (env->ExceptionOccured) {
>>        rc = 1;
>>   }
>>  (*jvm)->DetachCurrentThread(jvm);
>>  (*jvm)->DestroyJavaVM (jvm);
>>  return rc;
>> </snip>
>>
>> If there are no objections I'll come up with the patch soon...
>>
>> Thanks
>> Evgueni
>> On 10/30/06, Evgueni Brevnov <evgueni.brevnov@gmail.com> wrote:
>> > I'll try to see how to fix it for DRLVM
>> >
>> > Evgueni
>> >
>> > On 10/30/06, Evgueni Brevnov <evgueni.brevnov@gmail.com> wrote:
>> > > hmmm.... I got 0 for DRLVM on Win2003
>> > >
>> > > Evgueni
>> > >
>> > > On 10/30/06, Spark Shen <smallsmallorgan@gmail.com> wrote:
>> > > > Then we may need to follow RI, since different error code fails
>> application
>> > > >
>> > > > Best regards
>> > > > Tony Wu ??:
>> > > > > Consider this class,
>> > > > > public class TestExeReturn {
>> > > > > public static void main(String[] args) throws Exception {
>> > > > > throw new Exception();
>> > > > > }
>> > > > > }
>> > > > >
>> > > > > when we run "java TestExeReturn" and "echo %errorlevel%", we
>> got 1 of
>> > > > > RI, -1 of DRLVM and 0 for IBMVM.
>> > > > >
>> > > > > a testcase of apache ant failed for this issue.
>> > > > >
>> > > >
>> > > >
>> > > > --
>> > > > Spark Shen
>> > > > China Software Development Lab, IBM
>> > > >
>> > > >
>> > >
>> >
>>
> 

-- 

Tim Ellison (t.p.ellison@gmail.com)