Return-Path: Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org Received: (qmail 95510 invoked from network); 5 Oct 2006 09:54:01 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 5 Oct 2006 09:54:01 -0000 Received: (qmail 27800 invoked by uid 500); 5 Oct 2006 09:53:58 -0000 Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org Received: (qmail 27746 invoked by uid 500); 5 Oct 2006 09:53:58 -0000 Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-dev@incubator.apache.org Received: (qmail 27726 invoked by uid 99); 5 Oct 2006 09:53:57 -0000 Received: from idunn.apache.osuosl.org (HELO idunn.apache.osuosl.org) (140.211.166.84) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Oct 2006 02:53:57 -0700 Authentication-Results: idunn.apache.osuosl.org header.from=t.p.ellison@gmail.com; domainkeys=good X-ASF-Spam-Status: No, hits=1.7 required=5.0 tests=DNS_FROM_RFC_ABUSE,RCVD_IN_SORBS_WEB DomainKey-Status: good X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 Received: from [64.233.182.189] ([64.233.182.189:43502] helo=nf-out-0910.google.com) by idunn.apache.osuosl.org (ecelerity 2.1.1.8 r(12930)) with ESMTP id A9/62-20288-826D4254 for ; Thu, 05 Oct 2006 02:53:48 -0700 Received: by nf-out-0910.google.com with SMTP id c2so321821nfe for ; Thu, 05 Oct 2006 02:53:17 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding; b=DgsQRM3aR8fMJPO0lN51h44nGHZGB3ifQPKgD7hm5BTEMDuY3NJq/t04MVY/A500Vbk4DeIfa+DS1EnFeUQINPhkLIOMinIkC5zxqVgJdm/IxhY+y4Pgd7loTpMIgDzNNaKc0CHWipJCc+WA+emjBwsYz5U5MtadqdWue/Xf8ew= Received: by 10.48.163.19 with SMTP id l19mr3572931nfe; Thu, 05 Oct 2006 02:53:16 -0700 (PDT) Received: from ?9.20.183.70? ( [195.212.29.92]) by mx.google.com with ESMTP id i1sm3551471nfe.2006.10.05.02.53.15; Thu, 05 Oct 2006 02:53:16 -0700 (PDT) Message-ID: <4524D607.70702@gmail.com> Date: Thu, 05 Oct 2006 10:53:11 +0100 From: Tim Ellison User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: harmony-dev@incubator.apache.org Subject: Re: [r451637] - Code cleanup - ... - Remove unnecessary comments References: <006d01c6e81b$17237ac0$0501a8c0@LITTLEGUY> In-Reply-To: <006d01c6e81b$17237ac0$0501a8c0@LITTLEGUY> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Nathan Beyer wrote: >> From: Tim Ellison [mailto:t.p.ellison@gmail.com] >> >> Leave them in unless you put them in or are fixing it. > > I did put in a fix; I replaced the TODO with the stack trace print. It is my > OPINION that TODO comments are, in general (80%), crap, but I've only > replaced TODOs in Harmony with actual code or documentation. Sure -- I wasn't referring to this particular occasion, I was espousing a guideline on existing TODO's. Regards, Tim -- Tim Ellison (t.p.ellison@gmail.com) IBM Java technology centre, UK. --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org For additional commands, e-mail: harmony-dev-help@incubator.apache.org