Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
DomainKey-Status: good
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=MLe4uDmSfSNIzmTBYUxoysQONbH1mlTMJHcg4jaBTHcL5lUhHCqt8MkB5g21ddrz3OhtiTj3HgqR4TCG9Szy8H+RCeNmmSEwLvg8M+woQqdV2FJJpcwuhYouFVKbXgvgjhWMeO+RNtA+8igSknN1k5cTTJNLFabK2abQ903+700=
Message-ID: <3b3f27c60610031658l49fee490g5a5f80f60cd516c3@mail.gmail.com>
Date: Tue, 3 Oct 2006 18:58:30 -0500
From: "Nathan Beyer" <nbeyer@gmail.com>
To: harmony-dev@incubator.apache.org
Subject: Re: [r451637] - Code cleanup - ... - Remove unnecessary comments
In-Reply-To: <f944d83d0610030319s4f3967c7pee51a82dea2b8db@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <f944d83d0610030319s4f3967c7pee51a82dea2b8db@mail.gmail.com>

If this is an event that should be logged, as the TODO indicated, then
why not just print out the stack trace and be done with it? If this
exception happens so often that you'd like it removed, then why would
we want to log a warning message, which I would presume would print to
the console just as frequently.

As for TODOs, in general I find TODOs never get done, especially
trivial ones like this particular case.

-Nathan

On 10/3/06, Alexey Varlamov <alexey.v.varlamov@gmail.com> wrote:
> Nathan,
>
> I've seen you dropped many TODOs in "- Code cleanup -" series of commits;
> I'd like to know what reasoning was behind this? I think it's a bit
> early to erase TODOs without appropriate consideration...
>
> In particular, could you please undo the following change, it produces
> garbage messages during AUTH testing:
>
> modules/auth/src/main/java/common/org/apache/harmony/auth/login/DefaultConfigurationParser.java
> ===========
> @@ -216,12 +206,12 @@ public class DefaultConfigurationParser
> try {
> val = PolicyUtils.expand(st.sval, system);
> } catch (Exception e) {
> - //TODO: warning log
> - }
> + e.printStackTrace();
> + }
> }
>
> --
> WBR,
> Alexey
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org