Return-Path: Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org Received: (qmail 38871 invoked from network); 5 Oct 2006 12:08:15 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 5 Oct 2006 12:08:15 -0000 Received: (qmail 27488 invoked by uid 500); 5 Oct 2006 12:08:13 -0000 Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org Received: (qmail 27240 invoked by uid 500); 5 Oct 2006 12:08:12 -0000 Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-dev@incubator.apache.org Received: (qmail 27229 invoked by uid 99); 5 Oct 2006 12:08:12 -0000 Received: from idunn.apache.osuosl.org (HELO idunn.apache.osuosl.org) (140.211.166.84) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Oct 2006 05:08:12 -0700 Authentication-Results: idunn.apache.osuosl.org header.from=oleg.v.khaschansky@gmail.com; domainkeys=good X-ASF-Spam-Status: No, hits=0.5 required=5.0 tests=DNS_FROM_RFC_ABUSE DomainKey-Status: good X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 Received: from [66.249.82.227] ([66.249.82.227:60607] helo=wx-out-0506.google.com) by idunn.apache.osuosl.org (ecelerity 2.1.1.8 r(12930)) with ESMTP id 61/24-20288-D95F4254 for ; Thu, 05 Oct 2006 05:08:01 -0700 Received: by wx-out-0506.google.com with SMTP id s13so540420wxc for ; Thu, 05 Oct 2006 05:06:29 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=o6UCEMRApBndgBaWcSm3AYmpq6reRyPNHMCTUlocmpuoa44Xmt3DvSWVMePQK0/Q6+gykjBoeChLSc7zjEs0A451nh4wTtZnVkkp5fHoOUc3g8hJZMKpYZWg1xs08qYpJyoPuGLeV21EfkDOgAwtOBAMrgjH4R6SmsNxozmrN3s= Received: by 10.90.120.6 with SMTP id s6mr692082agc; Thu, 05 Oct 2006 05:06:28 -0700 (PDT) Received: by 10.90.51.7 with HTTP; Thu, 5 Oct 2006 05:06:28 -0700 (PDT) Message-ID: <26c14c2a0610050506v19e885f2lf3f99ff344814eaf@mail.gmail.com> Date: Thu, 5 Oct 2006 16:06:28 +0400 From: "Oleg Khaschansky" To: harmony-dev@incubator.apache.org Subject: Re: [classlib] enabling AWT/Swing by default (was: Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/depends.xml) In-Reply-To: <906dd82e0610042203y7226e2a8wa71321fe96ae4802@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20061004102431.751761A981A@eris.apache.org> <200610041428.k94ESG1g029308@d06av02.portsmouth.uk.ibm.com> <4523C818.1060906@gmail.com> <200610041447.k94EliAg005131@d06av02.portsmouth.uk.ibm.com> <906dd82e0610040813ha698644of31ade437282362@mail.gmail.com> <26c14c2a0610041142g4d060c6ese69e80f2eec3bc40@mail.gmail.com> <906dd82e0610042203y7226e2a8wa71321fe96ae4802@mail.gmail.com> X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Patch for the TransferHandlerTest failure is here: http://issues.apache.org/jira/browse/HARMONY-1723 On 10/5/06, Mikhail Loenko wrote: > 2006/10/5, Oleg Khaschansky : > > I found the reason of this failure. It is an IntrospectionException > > while executing a following method from the TransferHandler class: > > > > private PropertyDescriptor getPropertyDescriptor(final JComponent c) { > > PropertyDescriptor result = null; > > try { > > result = new PropertyDescriptor(propertyName, c.getClass()); > > } catch (IntrospectionException e) { > > > > } > > return result; > > } > > It tries to get the PropertyDescriptor for the class JButton and > > property name "insets", but fails because there's no setInsets method. > > So, flavors array stays uninitialized and getTransferDataFlavors > > method returns null which is a cause of a NPE. > > > > The quick fix for this issue could be changing this method to the following: > > > > private PropertyDescriptor getPropertyDescriptor(final JComponent c) { > > PropertyDescriptor result = null; > > try { > > return result = new PropertyDescriptor(propertyName, c.getClass()); > > } catch (IntrospectionException e) { > > } > > try { > > return result = new PropertyDescriptor(propertyName, > > c.getClass(), "1", null); > > } catch (IntrospectionException e) { > > } > > return result; > > } > > > > + we need to fix in beans the fact that the following code: > > > > new PropertyDescriptor(propertyName, c.getClass(), "1", null); > > > > will throw IntrospectionException on Harmony, but will return the > > valid property descriptor with the getter method on RI. > > > > Any thoughts on this? Or should I proceed with a patch for the both issues? > > Yes, please. When you submit a patch people will have a chance > to review and comment > > Thanks, > Mikhail > > > > > > Thanks, > > Oleg > > > > On 10/4/06, Mikhail Loenko wrote: > > > 2006/10/4, Mark Hindess : > > > > > > > > On 4 October 2006 at 15:41, Tim Ellison wrote: > > > > > Excuse the change in subject line... > > > > > > > > No problem. I was just cursing myself for having forgotten to change > > > > it. > > > > > > > > > Mark Hindess wrote: > > > > > > With this change, the awt dependencies should now be automated for > > > > > > windows and at least fairly trivial (installing a few packages on > > > > > > Linux[0]). I think it is time we removed the with.awt.swing flag. > > > > > > Anyone object? > > > > > > > > > > To the contrary, ditch it. > > > > > > > > > > > Please test the current setup with -Dwith.awt.swing=true and report any > > > > > > problems. > > > > > > > > > > Problem 1: My machine is too slow running all these tests. > > > > > > > > Mine too. And I have wondered if the hourly builds will finish within > > > > the hour now. We really should see if we can avoid the need to fork > > > > for every test. > > > > > > I've run the tests on my XP machine, 1 failed > > > > > > javax.swing.TransferHandlerTest#testCreateTransferable > > > > > > java.lang.NullPointerException at > > > javax.swing.TransferHandlerTest.testCreateTransferable(TransferHandlerTest.java:140) > > > at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25) > > > at javax.swing.BasicSwingTestCase.runBareSuper(BasicSwingTestCase.java:115) > > > at javax.swing.SwingTestCase$1.run(SwingTestCase.java:44) at > > > java.awt.event.InvocationEvent.runAndNotify(InvocationEvent.java:88) > > > at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:77) at > > > java.awt.EventQueueCore.dispatchEventImpl(EventQueueCore.java:131) at > > > java.awt.EventQueue.dispatchEvent(EventQueue.java:144) at > > > java.awt.EventDispatchThread.runModalLoop(EventDispatchThread.java:75) > > > at java.awt.EventDispatchThread.run(EventDispatchThread.java:48) > > > > > > Thanks, > > > Mikhail > > > > > > > > > > > > > > Regards, > > > > Mark. > > > > > > > > > Regards, > > > > > Tim > > > > > > > > > > > [0] Details of the required packages for distributions other than > > > > > > Debian/Ubuntu would be welcome. > > > > > > > > > > > > On 4 October 2006 at 10:24, hindessm@apache.org wrote: > > > > > >> Author: hindessm > > > > > >> Date: Wed Oct 4 03:24:29 2006 > > > > > >> New Revision: 452826 > > > > > >> > > > > > >> URL: http://svn.apache.org/viewvc?view=rev&rev=452826 > > > > > >> Log: > > > > > >> Update check/fetch depends targets to handle the awt dependencies. > > > > > >> > > > > > >> Modified: > > > > > >> incubator/harmony/enhanced/classlib/trunk/depends/libs/build/ (props > > > > > ch > > > > > >> anged) > > > > > >> incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/ > > > > > (pr > > > > > >> ops changed) > > > > > >> incubator/harmony/enhanced/classlib/trunk/make/depends.properties > > > > > >> incubator/harmony/enhanced/classlib/trunk/make/depends.xml > > > > > >> > > > > > >> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/ > > > > > >> -------------------------------------------------------------------------- > > > > > --- > > > > > >> - > > > > > >> --- svn:ignore (original) > > > > > >> +++ svn:ignore Wed Oct 4 03:24:29 2006 > > > > > >> @@ -1,3 +1,4 @@ > > > > > >> jpeg > > > > > >> lcms > > > > > >> png > > > > > >> +winxp_2006-09-28.txt > > > > > >> > > > > > >> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/windows > > > > > .x8 > > > > > >> 6/ > > > > > >> -------------------------------------------------------------------------- > > > > > --- > > > > > >> - > > > > > >> --- svn:ignore (original) > > > > > >> +++ svn:ignore Wed Oct 4 03:24:29 2006 > > > > > >> @@ -1 +1,2 @@ > > > > > >> msvcr71.dll > > > > > >> +swing_awt_deps_winxp_2006-09-28.tgz > > > > > >> > > > > > >> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.propertie > > > > > s > > > > > >> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun > > > > > k/m > > > > > >> ake/depends.properties?view=diff&rev=452826&r1=452825&r2=452826 > > > > > >> ========================================================================== > > > > > === > > > > > >> = > > > > > >> --- incubator/harmony/enhanced/classlib/trunk/make/depends.properties (ori > > > > > gin > > > > > >> al) > > > > > >> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Wed > > > > > Oct > > > > > >> 4 03:24:29 2006 > > > > > >> @@ -98,3 +98,11 @@ > > > > > >> servlet-api.jar=${jetty.dir}/servlet-api-2.5-6.0.0.jar > > > > > >> servlet-api.md5=c27c02fb0a00cc3a7d05ea993a9bf56e > > > > > >> servlet-api.url=${ibiblio.base}/maven2/jetty/servlet-api/2.5-6.0.0/servle > > > > > t-a > > > > > >> pi-2.5-6.0.0.jar > > > > > >> + > > > > > >> +people.apache.base=http://people.apache.org/~geirm/harmony/ > > > > > >> +awtdeps.dir=${depends.dir}/libs/windows.x86 > > > > > >> +awtdeps.tar=${awtdeps.dir}/swing_awt_deps_winxp_2006-09-28.tgz > > > > > >> +awtdeps.url=${people.apache.base}swing_awt_deps_winxp_2006-09-28.tgz > > > > > >> +awtdeps.md5=d61a27e4b305d9fcabaaacf34f8f534a > > > > > >> +awtdeps.extract.dir=${depends.dir}/libs/build > > > > > >> +awtdeps.testfile=${awtdeps.extract.dir}/winxp_2006-09-28.txt > > > > > >> > > > > > >> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml > > > > > >> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun > > > > > k/m > > > > > >> ake/depends.xml?view=diff&rev=452826&r1=452825&r2=452826 > > > > > >> ========================================================================== > > > > > === > > > > > >> = > > > > > >> --- incubator/harmony/enhanced/classlib/trunk/make/depends.xml (original) > > > > > >> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml Wed Oct 4 > > > > > 03: > > > > > >> 24:29 2006 > > > > > >> @@ -72,17 +72,22 @@ > > > > > >> > > > > > >> > > > > > >> > > > > > >> - > > > > > >> + > > > > >> + depends="-really-check-win,-awt-tar-extract" /> > > > > > >> + > > > > > >> + > > > > > >> > > > > > >> > > > > > >> > > > > > >> - > > > > > >> + > > > > > >> + > > > > > >> + > > > > >> + srcfile="${awtdeps.tar}" > > > > > >> + targetfile="${awtdeps.testfile}" /> > > > > > >> > > > > > >> - > > > > > >> - > > > > > >> > > > > > >> > > > > > >> - > > > > > >> + > > > > > >> > > > > > >> > > > > >> value="liblcms development package not installed > > > > > >> @@ -214,6 +219,10 @@ > > > > > >> > > > > >> md5="${msvcr71.md5}" /> > > > > > >> > > > > > >> + > > > > > >> + > > > > >> + md5="${awtdeps.md5}" /> > > > > > >> + > > > > > >> > > > > > >> > > > > > >> > > > > > >> @@ -298,6 +307,14 @@ > > > > > >> > > > > >> manifest="${bcprov.dir}/temp/META-INF/MANIFEST.MF" /> > > > > > >> > > > > > >> + > > > > > >> + > > > > > >> + > > > > > >> + Extracting awt dependencies > > > > > >> + > > > > >> + compression="gzip" /> > > > > > >> + > > > > >> + message="${awtdeps.tar} extracted${line.separator}" /> > > > > > >> > > > > > >> > > > > > >> > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > Terms of use : http://incubator.apache.org/harmony/mailing.html > > > > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > > > > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > Tim Ellison (t.p.ellison@gmail.com) > > > > > IBM Java technology centre, UK. > > > > > > > > > > --------------------------------------------------------------------- > > > > > Terms of use : http://incubator.apache.org/harmony/mailing.html > > > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > > > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > Terms of use : http://incubator.apache.org/harmony/mailing.html > > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > Terms of use : http://incubator.apache.org/harmony/mailing.html > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > > > > > > > > > --------------------------------------------------------------------- > > Terms of use : http://incubator.apache.org/harmony/mailing.html > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > > > > > --------------------------------------------------------------------- > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org For additional commands, e-mail: harmony-dev-help@incubator.apache.org