Return-Path: Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org Received: (qmail 90858 invoked from network); 16 Oct 2006 23:04:10 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 16 Oct 2006 23:04:10 -0000 Received: (qmail 4973 invoked by uid 500); 16 Oct 2006 23:04:07 -0000 Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org Received: (qmail 4858 invoked by uid 500); 16 Oct 2006 23:04:07 -0000 Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-dev@incubator.apache.org Received: (qmail 4847 invoked by uid 99); 16 Oct 2006 23:04:07 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Oct 2006 16:04:07 -0700 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=DNS_FROM_RFC_ABUSE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of ivan.volosyuk@gmail.com designates 64.233.182.184 as permitted sender) Received: from [64.233.182.184] (HELO nf-out-0910.google.com) (64.233.182.184) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Oct 2006 16:04:06 -0700 Received: by nf-out-0910.google.com with SMTP id a4so70872nfc for ; Mon, 16 Oct 2006 16:03:45 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=MfVQJb26XWot1xQHMQ36nge3X7sC+DgGe83IzReG8Fu8x7xv2FFJtd9sobTck5TJgNUEW+YAOUT/f/z7Hr/O0U7++6cTMRV70RkiJn2cJerZrjCD/71blj6neKq9WacANyUj+Y8zkYBO1gb1Ryws+NqViZ+Wz17AorvnxtMsKPE= Received: by 10.49.21.8 with SMTP id y8mr364629nfi; Mon, 16 Oct 2006 16:03:45 -0700 (PDT) Received: by 10.48.207.13 with HTTP; Mon, 16 Oct 2006 16:03:45 -0700 (PDT) Message-ID: <12385bbd0610161603h57afc3dfk78bac4273e9e9a43@mail.gmail.com> Date: Tue, 17 Oct 2006 03:03:45 +0400 From: "Ivan Volosyuk" To: harmony-dev@incubator.apache.org, geir@pobox.com Subject: Re: [drlvm] why not use a defined constant for max int? In-Reply-To: <4533F84D.9070607@pobox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <4533F84D.9070607@pobox.com> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On 10/17/06, Geir Magnusson Jr. wrote: > When reviewing HARMONY-1672, there are bits like > > res.i = (int32)2147483647; > > (not part of the patch, but surrounding code...) > > What is the downside for using INT32_MAX or something portable and > appropriate? Wouldnt' that make the code more readable? > > geir It is good to use something like. Is it really portable? I cannot find this define in MSVC. -- Ivan Intel Enterprise Solutions Software Division --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org For additional commands, e-mail: harmony-dev-help@incubator.apache.org