From harmony-dev-return-15065-apmail-incubator-harmony-dev-archive=incubator.apache.org@incubator.apache.org Thu Oct 05 13:32:23 2006 Return-Path: Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org Received: (qmail 71555 invoked from network); 5 Oct 2006 13:32:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 5 Oct 2006 13:32:23 -0000 Received: (qmail 74215 invoked by uid 500); 5 Oct 2006 13:32:05 -0000 Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org Received: (qmail 74055 invoked by uid 500); 5 Oct 2006 13:32:05 -0000 Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-dev@incubator.apache.org Received: (qmail 73972 invoked by uid 99); 5 Oct 2006 13:32:04 -0000 Received: from idunn.apache.osuosl.org (HELO idunn.apache.osuosl.org) (140.211.166.84) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Oct 2006 06:32:04 -0700 Authentication-Results: idunn.apache.osuosl.org header.from=alexei.zakharov@gmail.com; domainkeys=good X-ASF-Spam-Status: No, hits=0.5 required=5.0 tests=DNS_FROM_RFC_ABUSE DomainKey-Status: good X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 Received: from [66.249.92.172] ([66.249.92.172:59484] helo=ug-out-1314.google.com) by idunn.apache.osuosl.org (ecelerity 2.1.1.8 r(12930)) with ESMTP id 90/15-20288-04905254 for ; Thu, 05 Oct 2006 06:31:47 -0700 Received: by ug-out-1314.google.com with SMTP id y2so242385uge for ; Thu, 05 Oct 2006 06:30:57 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=sahWpHfVqEpsAzlTEm+Z0h/5obmZMbk/TY0qEXteXJH2DB7cg/Xl2QxKMUTpE5sE209GLIInPShbv0hhERxjcFABerWVKOGwty4p8JMFE9JUL5/zPUDHU6hYkUcF9uAlRPlFqe00hDJezlCNsSl+YbVgLhRF/JmBtyypr4cjNqM= Received: by 10.78.134.12 with SMTP id h12mr1862704hud; Thu, 05 Oct 2006 06:30:56 -0700 (PDT) Received: by 10.78.141.7 with HTTP; Thu, 5 Oct 2006 06:30:56 -0700 (PDT) Message-ID: <2c9597b90610050630m107cb9d0v8ab9cd19d4ff5780@mail.gmail.com> Date: Thu, 5 Oct 2006 17:30:56 +0400 From: "Alexei Zakharov" To: harmony-dev@incubator.apache.org Subject: Re: Re: [r451637] - Code cleanup - ... - Remove unnecessary comments In-Reply-To: <636fd28e0610040622y67a2928ah3108880dc787b7a3@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <3b3f27c60610031658l49fee490g5a5f80f60cd516c3@mail.gmail.com> <636fd28e0610040622y67a2928ah3108880dc787b7a3@mail.gmail.com> X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N > I'd say leave the TODOs alone, at least until we're in a phase where > such polishing up is desired. Agreed. I've already posted a lot of // XXX investigate messages to myself to be read in the future. Regards, 2006/10/4, Alex Blewitt : > I use TODOs a lot in my code to remind me to come back to that > particular piece and do the job properly. If someone else were to > remove them then they may not do the right thing as far as the code > needs ... so I'd expect at least some kind of heads-up before this > would happen :-) > > I'd say leave the TODOs alone, at least until we're in a phase where > such polishing up is desired. > > Alex. > > On 04/10/06, Nathan Beyer wrote: > > If this is an event that should be logged, as the TODO indicated, then > > why not just print out the stack trace and be done with it? If this > > exception happens so often that you'd like it removed, then why would > > we want to log a warning message, which I would presume would print to > > the console just as frequently. > > > > As for TODOs, in general I find TODOs never get done, especially > > trivial ones like this particular case. > > > > -Nathan > > > > On 10/3/06, Alexey Varlamov wrote: > > > Nathan, > > > > > > I've seen you dropped many TODOs in "- Code cleanup -" series of commits; > > > I'd like to know what reasoning was behind this? I think it's a bit > > > early to erase TODOs without appropriate consideration... > > > > > > In particular, could you please undo the following change, it produces > > > garbage messages during AUTH testing: > > > > > > modules/auth/src/main/java/common/org/apache/harmony/auth/login/DefaultConfigurationParser.java > > > =========== > > > @@ -216,12 +206,12 @@ public class DefaultConfigurationParser > > > try { > > > val = PolicyUtils.expand(st.sval, system); > > > } catch (Exception e) { > > > - //TODO: warning log > > > - } > > > + e.printStackTrace(); > > > + } > > > } > > > > > > -- > > > WBR, > > > Alexey > > > > > > --------------------------------------------------------------------- > > > Terms of use : http://incubator.apache.org/harmony/mailing.html > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > > > > > > > > > --------------------------------------------------------------------- > > Terms of use : http://incubator.apache.org/harmony/mailing.html > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > > > > > --------------------------------------------------------------------- > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > > -- Alexei Zakharov, Intel Middleware Product Division --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org For additional commands, e-mail: harmony-dev-help@incubator.apache.org