harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov" <alexey.v.varla...@gmail.com>
Subject Re: [classlib][swing] test "hangs": j.s.filechooser.FileSystemViewTest prompts to insert disk into drive A:
Date Tue, 17 Oct 2006 12:40:54 GMT
2006/10/17, Ivanov, Alexey A <alexey.a.ivanov@intel.com>:
> Hello everyone,
>
> When running tests on Windows,
> FileSystemViewTest.testGetSystemDisplayName() pops up a dialog prompting
> to insert disk into drive A:. This dialog prevents normal running of
> other tests.
>

LOL

> IMO, the problem assertion could be deleted without loss of coverage.
> Any other comments/opinions?
>
> See the JIRA issue: https://issues.apache.org/jira/browse/HARMONY-1892
>
>
> Regards,
> Alexey.
>
>
> P.S. The problem code is at lines 85-86 in FileSystemViewTest.java:
>        file = File.listRoots()[0];
>        assertNotSame(file.getName(), view.getSystemDisplayName(file));

The assertion doesn't look foolproof anyway. Accordingly to spec
getSystemDisplayName() should return *some* name, max what we may
assert that it is not null and not empty.

>
> --
> Alexey A. Ivanov
> Intel Middleware Product Division
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message