harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov" <alexey.v.varla...@gmail.com>
Subject [r451637] - Code cleanup - ... - Remove unnecessary comments
Date Tue, 03 Oct 2006 10:19:45 GMT
Nathan,

I've seen you dropped many TODOs in "- Code cleanup -" series of commits;
I'd like to know what reasoning was behind this? I think it's a bit
early to erase TODOs without appropriate consideration...

In particular, could you please undo the following change, it produces
garbage messages during AUTH testing:

modules/auth/src/main/java/common/org/apache/harmony/auth/login/DefaultConfigurationParser.java
===========
@@ -216,12 +206,12 @@ public class DefaultConfigurationParser
try {
val = PolicyUtils.expand(st.sval, system);
} catch (Exception e) {
- //TODO: warning log
- }
+ e.printStackTrace();
+ }
}

--
WBR,
Alexey

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message