harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Evgueni Brevnov" <evgueni.brev...@gmail.com>
Subject Re: [drlvm][eclipse compiler] the test compiled with ECJ fails on drlvm
Date Mon, 30 Oct 2006 11:43:17 GMT
Alexey,

I didn't mean to fix getEnclosing method impl itself. Yes the compiler
should provide such info. Sorry for confusion...

Evgueni

On 10/30/06, Alexey Varlamov <alexey.v.varlamov@gmail.com> wrote:
> 2006/10/30, Nathan Beyer <nbeyer@gmail.com>:
> > I see that one of the ECJ bugs has been fixed [1], but the other was
> > closed awaiting more information [2], but may be resolved as well.
> >
> > The fix should be available to test from a nightly build of the
> > Eclipse 3.3 stream. Would someone like to verify that the discussed
> > issues are resolved?
>
> Nathan, I've verified [2].
>
> Elena, Evgueni,
>
> The H-1931_ReflectExporter.patch is really the proper fix, thank you.
> Regarding the question 3) of Evgueni's earlier post, I believe there
> is nothing to fix in getEnclosingClass() impl: if compiler did not
> care to provide such info, there is no reliable way to determine it
> (using class name etc). And provided [1] is fixed in ECJ, Elena's
> tests should pass.
>
> --
> Alexey
>
> >
> > [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=162296
> > [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=162356
>
>
>
> > On 10/26/06, Tim Ellison <t.p.ellison@gmail.com> wrote:
> > > Elena Semukhina wrote:
> > > > On 10/26/06, Nathan Beyer <nbeyer@gmail.com> wrote:
> > > >>
> > > >> If this is a bug, have you logged an issue with Eclipse? If not,
> > > >> please do so and post the bug URL here, so we can monitor it. You
may
> > > >> want to try compiling this with the latest ECJ JAR (3.3 nightly) to
> > > >> see if it's still generating the same bytecode.
> > > >
> > > >
> > > > Nathan, here is the bug URL:
> > > > https://bugs.eclipse.org/bugs/show_bug.cgi?id=162356
> > > > I tried ecj.jar 3.3 and still was able to reproduce the bug.
> > > >
> > > > Considering that the RI can run this code fine, I'd be surprised if
> > > >> this is considered a bug. I've been surprised before though. :)
> > > >
> > > >
> > > > The test I submitted to Eclipse bugzilla fails on RI, IBM VM and DRLVM
when
> > > > compiled with ECJ and passes being compiled with javac.
> > > >
> > > > The fix submitted to H-1931 takes this bug into account and relies on
the
> > > > private modifier of a local class which is provided by Eclipse compiler
> > > > (but
> > > > not provided by javac). So the accessibility control algorithm takes
> > > > different branches for the classes compiled with javac and ECJ for now.
> > >
> > > See also
> > >         https://bugs.eclipse.org/bugs/show_bug.cgi?id=162296
> > >
> > > which I have cross-referenced to Bug#162356.
> > >
> > > Regards,
> > > Tim
> > >
> > > --
> > >
> > > Tim Ellison (t.p.ellison@gmail.com)
> > >
> > >
> >
>

Mime
View raw message