harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Evgueni Brevnov" <evgueni.brev...@gmail.com>
Subject Re: [drlvm] too tired, need help
Date Fri, 06 Oct 2006 06:55:30 GMT
I can't provide you with the fresh patch right now. I want to restrore
cunit tests first.
If it doesn't introduce many changes then go ahead and commit. It
should be easy to merge then.

Evgueni

On 10/6/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
> And it would only introduce a few, as far as I can tell, as only jni.cpp
> and vm_main.cpp actually include init.h, and therefore are the only
> files that depend on that global
>
> geir
>
> Evgueni Brevnov wrote:
> > Geir,
> >
> > Please don't do that until HARMONY-1582 integration. It can introduce
> > many conflicts.
> >
> > Tnanks in advance.
> > Evgueni
> >
> > On 10/6/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
> >> I got it - thanks to Pavel.
> >>
> >> There's an extern in init.h, and it's declared in vm_main.cpp.
> >>
> >> Would anyone mind if I renamed it something less innocuous like
> >>
> >> global_env
> >> vm_global_env
> >>
> >> Something that gives the reader the hint that it's not a local var.
> >>
> >> geir
> >>
> >>
> >> Geir Magnusson Jr. wrote:
> >> > Thank you.
> >> >
> >> > How does the compiler know this when compiling jni.cpp?  is there an
> >> > extern defn somewhere?
> >> >
> >> > geir
> >> >
> >> > Pavel Rebriy wrote:
> >> >> File vm/vmcore/src/init/vm_main.cpp, line 68.
> >> >>
> >> >> Global_Env env(m, properties);
> >> >>
> >> >> On 06/10/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
> >> >>>
> >> >>> I know the type.  The question is where is that variable "env"
> >> declared
> >> >>> and set?
> >> >>>
> >> >>> geir
> >> >>>
> >> >>>
> >> >>>
> >> >>> Weldon Washburn wrote:
> >> >>> > The first parameter to create_vm() is of type Global_Env.
> >> >>> >
> >> >>> > Global_Env is defined in environment.h
> >> >>> >
> >> >>> > vm_init() in vm_init.cpp initializes a bunch of Globla_Env's
> >> members.
> >> >>> >
> >> >>> >
> >> >>> >
> >> >>> >
> >> >>> > On 10/5/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
> >> >>> >>
> >> >>> >> I'm trying to trace through the boot sequence chasing
some boot
> >> >>> >> classpath property thing (luniglob sets it, and I can't
figure
> >> how it
> >> >>> >> gets to us...), and I'm too tired, too dumb, or both to
figure
> >> this
> >> >>> out.
> >> >>> >>
> >> >>> >> Launcher calls JNI_CreateJavaVM.  In our
> >> vmcore/src/jni/jni.cpp, we
> >> >>> >> define it, and it is  :
> >> >>> >>
> >> >>> >> VMEXPORT jint
> >> >>> >> JNICALL JNI_CreateJavaVM(JavaVM **p_vm, JNIEnv **p_env,
void
> >> >>> *vm_args)
> >> >>> {
> >> >>> >>
> >> >>> >>     static int called = 0;
> >> >>> >>
> >> >>> >>     init_log_system();
> >> >>> >>     TRACE2("jni", "CreateJavaVM called");
> >> >>> >>     if (called) {
> >> >>> >>         ASSERT(0, "Not implemented");
> >> >>> >>         return JNI_ERR;
> >> >>> >>     } else {
> >> >>> >>         create_vm(&env, (JavaVMInitArgs *)vm_args);
> >> >>> >>         *p_env = &jni_env;
> >> >>> >>         *p_vm = jni_env.vm;
> >> >>> >>         return JNI_OK;
> >> >>> >>     }
> >> >>> >> }
> >> >>> >>
> >> >>> >> For the life of me, I can't figure out where "env" is
defined
> >> or set.
> >> >>> >> create_vm() uses it...
> >> >>> >>
> >> >>> >> Can anyone give me a hint?  Eclipse's C++ plugin seems
to be
> >> useless
> >> >>> >> here...
> >> >>> >>
> >> >>> >> geir
> >> >>> >>
> >> >>> >>
> >> ---------------------------------------------------------------------
> >> >>> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> >>> >> To unsubscribe, e-mail:
> >> harmony-dev-unsubscribe@incubator.apache.org
> >> >>> >> For additional commands, e-mail:
> >> >>> harmony-dev-help@incubator.apache.org
> >> >>> >>
> >> >>> >>
> >> >>> >
> >> >>> >
> >> >>>
> >> >>> ---------------------------------------------------------------------
> >> >>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> >>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> >>> For additional commands, e-mail:
> >> harmony-dev-help@incubator.apache.org
> >> >>>
> >> >>>
> >> >>
> >> >>
> >> >
> >> > ---------------------------------------------------------------------
> >> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >> >
> >>
> >> ---------------------------------------------------------------------
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >>
> >>
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message