harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Fursov" <mike.fur...@gmail.com>
Subject Re: [drlvm][jit] Internal testing framework for Jitrino.OPT compiler
Date Tue, 03 Oct 2006 15:08:25 GMT
Ivan,
Thank you for the fix.
I checked the diff and it looks OK.
Actually, with this patch you remove the extra state from CFG - the special
behaviour of CFG without exit/entry nodes. And I think that this is right.
Now it's time to ask commiters to apply the patch.


On 10/3/06, Ivan Kollegov <kollegov.ivan@gmail.com> wrote:
>
> Hi Mikhail,
>
> I created fix for this bag and posted my diff to
> https://issues.apache.org/jira/browse/HARMONY-1665
> I added 2 "ifs" for entry and exit nodes, to verify if the node is not
> null. If the node is null, then return.
>
> Can you check my fix?
>
>
> On 9/27/06, Mikhail Fursov <mike.fursov@gmail.com> wrote:
> > Ivan,
> > I've checked all of the tests - this is very good beginning!
> > I see 2 directions to advance:
> > 1) Integrate Jitrino tests into common harmony test system. So we can
> ask
> > people to use our test suite.
> > 2) Start to test not only CFG but more complex IR examples. I mean to
> test
> > IR with instructions using optimizations.
> >
> > I want to get item 1 as TODO for myself. Could you take item 2 and write
> > several IR templates with instructions and use these templates in tests?
> >
> >
> > getNodeCountTest2 - this is a real bug. This bug does not affect any of
> JIT
> > algorithms today, but anyway it must be fixed.
> > Could you create and post the fix into JIRA? If you have questions I can
> > help you with the fix.
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


-- 
Mikhail Fursov

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message