harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Loenko" <mloe...@gmail.com>
Subject Re: [jira] Commented: (HARMONY-1670) [classlib][luni] invalid testcase in ClassTest
Date Thu, 12 Oct 2006 03:53:39 GMT
Sorry, I probably need more coffee.

What is "This" ?

Do you mean that you have reviewed the patch previously attached by Alexey V.
and found it good enough?

BTW, what is the reason to remove a part of the test? Are the checks invalid
or VM-specific?

Thanks,
Mikhail

2006/10/12, Fedotov, Alexei A <alexei.a.fedotov@intel.com>:
> Mikhail,
>
> >I don't understand either: "This is a low risk test fix".
>
> Here should be the following text:
>
> This is a fix of the test. Test fixes rarely affect more than one test,
> they are local. Hence, they wouldn't produce painful errors which took
> many geek/weeks to locate.
>
> With best regards,
> Alexei Fedotov,
> Intel Middleware Products Division
>
> >-----Original Message-----
> >From: Mikhail Loenko [mailto:mloenko@gmail.com]
> >Sent: Wednesday, October 11, 2006 5:57 PM
> >To: harmony-dev@incubator.apache.org
> >Subject: Re: [jira] Commented: (HARMONY-1670) [classlib][luni] invalid
> >testcase in ClassTest
> >
> >I don't understand either: "This is a low risk test fix".
> >
> >2006/10/11, Fedotov, Alexei A <alexei.a.fedotov@intel.com>:
> >> Mikhail,
> >>
> >> I already got several personal feedbacks about these comments. I
> accept
> >> that they are not good.
> >>
> >> I tried to express an idea that JIRAs marked with this comment
> prevent
> >> getting 100% pass rate on DRLVM. When I search for
> >> Unit_Tests_Pass_on_DRLVM in comments I will get a list of bugs to
> fix.
> >>
> >> Any suggestions how the comment should like? My only requirement is
> to
> >> keep Unit_Tests_Pass_on_DRLVM lexem in this comment.
> >
> >IMHO It makes sense to discuss it on a separate thread with different
> >subject,
> >so that other people could notice that discussion and participate
> >
> >Thanks,
> >Mikhail
> >
> >>
> >> With best regards,
> >> Alexei Fedotov,
> >> Intel Middleware Products Division
> >>
> >> >-----Original Message-----
> >> >From: Mikhail Loenko [mailto:mloenko@gmail.com]
> >> >Sent: Wednesday, October 11, 2006 2:37 PM
> >> >To: harmony-dev@incubator.apache.org
> >> >Subject: Re: [jira] Commented: (HARMONY-1670) [classlib][luni]
> invalid
> >> >testcase in ClassTest
> >> >
> >> >Hi Alexei
> >> >
> >> >I'm sorry I comlpetely don't understand your comment (as well as a
> >> >number of similar comments in other JIRAs)
> >> >
> >> >Thanks,
> >> >Mikhail
> >> >
> >> >2006/10/7, Alexei Fedotov (JIRA) <jira@apache.org>:
> >> >>    [ http://issues.apache.org/jira/browse/HARMONY-
> >> >1670?page=comments#action_12440591 ]
> >> >>
> >> >> Alexei Fedotov commented on HARMONY-1670:
> >> >> -----------------------------------------
> >> >>
> >> >> [drlvm][unit] Blocks
> >> >http://wiki.apache.org/harmony/Unit_Tests_Pass_on_DRLVM
> >> >>
> >> >> This is a low risk test fix.
> >> >>
> >> >> > [classlib][luni] invalid testcase in ClassTest
> >> >> > ----------------------------------------------
> >> >> >
> >> >> >                 Key: HARMONY-1670
> >> >> >                 URL:
> >> http://issues.apache.org/jira/browse/HARMONY-1670
> >> >> >             Project: Harmony
> >> >> >          Issue Type: Bug
> >> >> >          Components: Classlib
> >> >> >            Reporter: Alexey Varlamov
> >> >> >            Priority: Trivial
> >> >> >         Attachments: H-1670.patch
> >> >> >
> >> >> >
> >> >> > The test_getDeclaredMethodLjava_lang_String$Ljava_lang_Class of
> >>
> >modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/Clas
> >> sTes
> >> >t.java
> >> >> > checks if IllegalAccessException is thrown during invokation of
> >> private
> >> >method of inner class. This is bad due to:
> >> >> > 1) the check is invalid, see HARMONY-1309 for details;
> >> >> > 2) The ClassTest is not appropriate for testing reflection, and
> >> this is
> >> >already covered in j.l.reflect.* tests.
> >> >>
> >> >> --
> >> >> This message is automatically generated by JIRA.
> >> >> -
> >> >> If you think it was sent incorrectly contact one of the
> >> administrators:
> >> >http://issues.apache.org/jira/secure/Administrators.jspa
> >> >> -
> >> >> For more information on JIRA, see:
> >> http://www.atlassian.com/software/jira
> >> >>
> >> >>
> >> >>
> >> >
> >>
> >---------------------------------------------------------------------
> >> >Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> >To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> >For additional commands, e-mail:
> harmony-dev-help@incubator.apache.org
> >>
> >> ---------------------------------------------------------------------
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail:
> harmony-dev-help@incubator.apache.org
> >>
> >>
> >
> >---------------------------------------------------------------------
> >Terms of use : http://incubator.apache.org/harmony/mailing.html
> >To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message