harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Denis Kishenko" <dkishe...@gmail.com>
Subject Re: [classlib] Build failure messages
Date Fri, 20 Oct 2006 06:32:23 GMT
I have made fix[1]  for "unused" category (only java code). If nobody
has objections I could fix other caterogies.

[1] http://issues.apache.org/jira/browse/HARMONY-1926

2006/10/20, Nathan Beyer <nbeyer@gmail.com>:
> I've been trying to work through many of the warnings, module by
> module. Most of the warnings fall into the following categories.
> * serial - Serializable classes that don't have explicit serialVersionUID fields
> * unchecked - missing type variables, mostly collection references
> * unused - unused private fields, methods; these are tough as some of
> them are seemingly used by native code
> * missing @Override - methods that override other methods are
> annotated for safety
>
> -Nathan
>
> On 10/19/06, Tim Ellison <t.p.ellison@gmail.com> wrote:
> > Nathan has turned off all warnings.  I suggest that we start to turn
> > them back on incrementally and fix the warnings we see.
> >
> > Regards,
> > Tim
> >
> > Denis Kishenko wrote:
> > > I also worried about a lot of warnings and I think warnings like these
> > > can be fixed
> > >
> > > last\modules\concurrent\standard\src\main\java\java\util\concurrent\ConcurrentHashMap.java
> > >
> > >    [javac]  (at line 26)
> > >    [javac]     import java.io.ObjectInputStream;
> > >    [javac]            ^^^^^^^^^^^^^^^^^^^^^^^^^
> > >    [javac] The import java.io.ObjectInputStream is never used
> > >
> > >    [javac] 34. WARNING in
> > > C:\Work\Projects\Harmony-last\modules\concurrent\standard\src\main\java\java\util\concurrent\CountDownLatch.java
> > >
> > >    [javac]  (at line 130)
> > >    [javac]     private static final class Sync extends
> > > AbstractQueuedSynchronizer {
> > >    [javac]                                ^^^^
> > >    [javac] The serializable class Sync does not declare a static
> > > final serialVersionUID field of type long
> > >
> > > 2006/10/19, Nathan Beyer <nbeyer@gmail.com>:
> > >> I added a compiler arg to the main 'build-java.xml' compile to disable
> > >> all of the warnings.
> > >>
> > >> This should take care of the warnings.
> > >>
> > >> -Nathan
> > >>
> > >> On 10/18/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
> > >> > Can we just shut them off for now?  it's a good project for someone
to
> > >> > go and clean those up, but there's no need for all of us to see them.
> > >> >
> > >> > geir
> > >> >
> > >> > Mark Hindess wrote:
> > >> > > These messages aren't getting through on the commits list on
due
> > >> to the
> > >> > > large number of warnings since switching to ecj.  I've modified
the
> > >> > > summary process so that it ignores these for the moment.
> > >> > >
> > >> > > Hopefully this means that the failure messages that haven't been
> > >> making
> > >> > > the commits list will start getting through.
> > >> > >
> > >> > > Regards,
> > >> > >  Mark.
> > >> > >
> > >> > >
> > >> > >
> > >> > >
> > >> > > ---------------------------------------------------------------------
> > >> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > >> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > >> > > For additional commands, e-mail:
> > >> harmony-dev-help@incubator.apache.org
> > >> > >
> > >> >
> > >> > ---------------------------------------------------------------------
> > >> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > >> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > >> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >> >
> > >> >
> > >>
> > >> ---------------------------------------------------------------------
> > >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> > >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >>
> > >>
> > >
> > >
> >
> > --
> >
> > Tim Ellison (t.p.ellison@gmail.com)
> > IBM Java technology centre, UK.
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


-- 
Denis M. Kishenko
Enterprise Solutions Software Division

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message