harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geir Magnusson Jr." <g...@pobox.com>
Subject Re: [drlvm][jit] Internal testing framework for Jitrino.OPT compiler
Date Fri, 27 Oct 2006 14:57:28 GMT


Egor Pasko wrote:
> On the 0x20F day of Apache Harmony Geir Magnusson, Jr. wrote:
>> While you're at it, I'd like to get this patches in, but we probably
>> need a new target for building, as running normally with this
>> framework compiled in leads to problems.
>>
>> Can we find a way to make it a different build target, or at least a flag
>>
>>     -Dwith.jitrino.test.framework
>>
>> or something?
>>
>> (Apologies if you've already done that :)
> 
> we hope it would be a subset of pre-commit tests. So, this option
> should be ON in debug mode. Sounds good?
> 

+1

(as long as other stuff runs :)

>> geir
>>
>> Mikhail Fursov wrote:
>>> Thank you Ivan.
>>> The problem you found with TestRegistry.cpp will be fixed with the next my
>>> patch for Jitrino testing framework.
>>> I'll check all of your tests this weekend and post comments.
>>> On 10/27/06, Ivan Kollegov <kollegov.ivan@gmail.com> wrote:
>>>> Hi JIT developers.
>>>>
>>>> I've wrote 4 templates and about 20 tests to test Jitrino's internal
>>>> algorithms. I put them all into JIRA-1586
>>>>
>>>> Also I've founded a problem with testing simplifier.cpp (test
>>>> testSimplifyIf). The problem was in
>>>>
>>>> FlowGraph::foldBranch(ControlFlowGraph& fg, Node* block, BranchInst*
>>>> br, bool isTaken)
>>>>
>>>> {
>>>>     assert(br == block->getLastInst());
>>>>     assert(block->getOutDegree() == 2);
>>>>      fg.removeEdge(block->getOutEdge(isTaken ? Edge::Kind_False :
>>>> Edge::Kind_True));
>>>>      br->unlink();
>>>> }
>>>>
>>>> The variable "block" can be null. This problem can be fixed with patch
>>>> in JIRA-1986
>>>>
>>>> Also, I had problems with race condition with initializing of static
>>>> section in TestRegistry* TestRegistry::getInstance(){
>>>>
>>>> Could you check the changes?
>>>>
> 

Mime
View raw message