harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geir Magnusson Jr." <g...@pobox.com>
Subject Re: [drlvm] the big soup of VM properties (HARMONY-1626)
Date Tue, 10 Oct 2006 15:53:21 GMT


Dmitry Yershov wrote:
> [snip]
>> >                             Requirements
>> >                             ============
>> >
>> >     1) The <key> and <value> are represented as string (i.e. char*).
>>
>> and I propose that on each operation, a copy is made, so that the caller
>>   frees the  string that they got or gave.
>>
> 
> Agree.
> 
> ......
> 
> [snip]
>> 1) if this is a C++ class, lets drop the word 'property'
> 
> We can not drop this word because these interfaces are exported from VM 
> core.
> To my mind external interfaces should have useful names.

Agreed if it's not C++, but if so then it's redundant.

Property->getProperty(key) vs Property->get(key)

> 
>> 2) Don't hardcode 'hidden' into the API, as we may have other types down
>> the road.  Make it an argument
> 
> Ok. So, the latest list of interface functions should be:
> 
>    void set_property(const char * key, const char * value, bool type)
>    const char * get_property(const char * key, bool type)
>    bool is_property_set(const char * key, bool type)
>    void unset_property(const char * key, bool type)
>    char * * get_properties_keys(bool type)
>    char * * get_properties_keys_staring_with(const char * prefix, bool 
> type)
> 
> 
> 
> If there are no other objections i'll file a jira, start redeveloping
> property module, and then do source code refactoring.
> 
> Dmitry
> 
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message