harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Ellison <t.p.elli...@gmail.com>
Subject Re: [r451637] - Code cleanup - ... - Remove unnecessary comments
Date Wed, 04 Oct 2006 16:16:44 GMT
Alex Blewitt wrote:
> I use TODOs a lot in my code to remind me to come back to that
> particular piece and do the job properly. If someone else were to
> remove them then they may not do the right thing as far as the code
> needs ... so I'd expect at least some kind of heads-up before this
> would happen :-)
> 
> I'd say leave the TODOs alone, at least until we're in a phase where
> such polishing up is desired.

+1

Leave them in unless you put them in or are fixing it.

Regards,
Tim

> On 04/10/06, Nathan Beyer <nbeyer@gmail.com> wrote:
>> If this is an event that should be logged, as the TODO indicated, then
>> why not just print out the stack trace and be done with it? If this
>> exception happens so often that you'd like it removed, then why would
>> we want to log a warning message, which I would presume would print to
>> the console just as frequently.
>>
>> As for TODOs, in general I find TODOs never get done, especially
>> trivial ones like this particular case.
>>
>> -Nathan
>>
>> On 10/3/06, Alexey Varlamov <alexey.v.varlamov@gmail.com> wrote:
>> > Nathan,
>> >
>> > I've seen you dropped many TODOs in "- Code cleanup -" series of
>> commits;
>> > I'd like to know what reasoning was behind this? I think it's a bit
>> > early to erase TODOs without appropriate consideration...
>> >
>> > In particular, could you please undo the following change, it produces
>> > garbage messages during AUTH testing:
>> >
>> >
>> modules/auth/src/main/java/common/org/apache/harmony/auth/login/DefaultConfigurationParser.java
>>
>> > ===========
>> > @@ -216,12 +206,12 @@ public class DefaultConfigurationParser
>> > try {
>> > val = PolicyUtils.expand(st.sval, system);
>> > } catch (Exception e) {
>> > - //TODO: warning log
>> > - }
>> > + e.printStackTrace();
>> > + }
>> > }
>> >
>> > --
>> > WBR,
>> > Alexey
>> >
>> > ---------------------------------------------------------------------
>> > Terms of use : http://incubator.apache.org/harmony/mailing.html
>> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>> >
>> >
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
> 
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> 
> 

-- 

Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message