harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oliver Deakin <oliver.dea...@googlemail.com>
Subject Re: [r451637] - Code cleanup - ... - Remove unnecessary comments
Date Wed, 04 Oct 2006 13:37:38 GMT
Geir Magnusson Jr. wrote:
> Stepan Mishura wrote:
>> On 10/4/06, Nathan Beyer wrote:
>>>
>>> If this is an event that should be logged, as the TODO indicated, then
>>> why not just print out the stack trace and be done with it? If this
>>> exception happens so often that you'd like it removed, then why would
>>> we want to log a warning message, which I would presume would print to
>>> the console just as frequently.
>>>
>>> As for TODOs, in general I find TODOs never get done, especially
>>> trivial ones like this particular case.
>>
>>
>>
>> I don't agree. TODOs are good hint for making improvements and I'd 
>> keep them
>> in source files.
>
> Me too.  I don't like cruft, but I'm not sure I see the harm in general.

Agreed - Id prefer to keep the TODOs in there. They act as pointers for 
bits of
work that need to be done, and can be helpful to people looking to make 
small
contributions of effort to the project.

Regards,
Oliver

>
> geir
>
>>
>> Thanks,
>> Stepan.
>>
>> -Nathan
>>>
>>> On 10/3/06, Alexey Varlamov <alexey.v.varlamov@gmail.com> wrote:
>>> > Nathan,
>>> >
>>> > I've seen you dropped many TODOs in "- Code cleanup -" series of
>>> commits;
>>> > I'd like to know what reasoning was behind this? I think it's a bit
>>> > early to erase TODOs without appropriate consideration...
>>> >
>>> > In particular, could you please undo the following change, it 
>>> produces
>>> > garbage messages during AUTH testing:
>>> >
>>> >
>>> modules/auth/src/main/java/common/org/apache/harmony/auth/login/DefaultConfigurationParser.java

>>>
>>> > ===========
>>> > @@ -216,12 +206,12 @@ public class DefaultConfigurationParser
>>> > try {
>>> > val = PolicyUtils.expand(st.sval, system);
>>> > } catch (Exception e) {
>>> > - //TODO: warning log
>>> > - }
>>> > + e.printStackTrace();
>>> > + }
>>> > }
>>> >
>>> > --
>>> > WBR,
>>> > Alexey
>>>
>>>
>> ------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>

-- 
Oliver Deakin
IBM United Kingdom Limited


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message