harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Zakharov" <alexei.zakha...@gmail.com>
Subject Re: [jira] Updated: (HARMONY-1763) [classlib][beans] method java.beans.PropertyDescriptor.equals(Object) throws ClassCastException
Date Fri, 06 Oct 2006 17:23:26 GMT
Oleg,

Can we write the same logic a little bit nicer?
Something like:

   public boolean equals(Object object) {
-        boolean result = (object != null  && object instanceof
PropertyDescriptor);
-        if (result) {
+        boolean result = false;
+
+        if (object != null && object instanceof PropertyDescriptor) {
            PropertyDescriptor pd = (PropertyDescriptor) object;

Anyway +1 for the patch in general, thank you for finding this!

Regards,

2006/10/6, Oleg Khaschansky <oleg.v.khaschansky@gmail.com>:
> According to the "good issue resolution guideline" I am forwarding
> this to the dev. list.
>
> ---------- Forwarded message ----------
> From: Oleg Khaschansky (JIRA) <jira@apache.org>
> Date: Oct 6, 2006 8:58 PM
> Subject: [jira] Updated: (HARMONY-1763) [classlib][beans] method
> java.beans.PropertyDescriptor.equals(Object) throws ClassCastException
> To: harmony-commits@incubator.apache.org
>
>
>     [ http://issues.apache.org/jira/browse/HARMONY-1763?page=all ]
>
> Oleg Khaschansky updated HARMONY-1763:
> --------------------------------------
>
>    Attachment: harmony-1763.patch
>
> Patch for this issue rev. 453254.
>
> > [classlib][beans] method java.beans.PropertyDescriptor.equals(Object) throws ClassCastException
> > -----------------------------------------------------------------------------------------------
> >
> >                 Key: HARMONY-1763
> >                 URL: http://issues.apache.org/jira/browse/HARMONY-1763
> >             Project: Harmony
> >          Issue Type: Bug
> >          Components: Classlib
> >            Reporter: Oleg Khaschansky
> >            Priority: Minor
> >         Attachments: harmony-1763-test.patch, harmony-1763.patch
> >
> >
> > The test below throws ClassCastException on Harmony but passes on RI.
> > I will provide a patch for this issue and a unit test.
> > ----------------------------------------------------------------
> > import java.beans.*;
> > import java.lang.reflect.*;
> > public class Test {
> >         public static void main(String[] args) {
> >                 PropertyDescriptor toRet = null;
> >                 try {
> >                         toRet = new PropertyDescriptor("p", Bean.class );
> >                         toRet.setBound( true );
> >                 } catch (IntrospectionException e) {
> >                         e.printStackTrace();
> >                 }
> >                 Method m = null;
> >                 try {
> >                         m = HelpClass.class.getDeclaredMethod("f_static",
> > (Class[])null);
> >                 } catch (NoSuchMethodException e) {
> >                         e.printStackTrace();
> >                 }
> >                 toRet.equals(m);
> >                 System.out.println("PASSED");
> >         }
> > }
> > class Bean {
> >     public void setP(int i) {}
> >     public int getP() {return 0;}
> > }
> > class HelpClass {
> >         public HelpClass () {}
> >         public static void f_static () {}
> > }
> > ----------------------------------------------------------------


-- 
Alexei Zakharov,
Intel Middleware Product Division

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message