harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Khaschansky" <oleg.v.khaschan...@gmail.com>
Subject [classlib][awt] Revision #465514 broke image decoders.
Date Tue, 24 Oct 2006 13:25:46 GMT
Hi,

Rev. 465514 introduced a lot of invalid modifications to the
GifDecoder, PngDecoder and JpegDecoder. There were a number of fields
modified or initialized from the native code only, but they were
redeclared as final, so the decoders doesn't work properly any more.

This revision has the following comment:

Cleanup code
* Add if/else braces
* Add missing annotations
* Add type variables
* Use foreach loops
* etc

I'd suggest to roll back this revision and redo the cleanup in the
more accurate way.

Thanks,
  Oleg

Mime
View raw message