Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Received-SPF: pass (idunn.apache.osuosl.org: domain gmail.com designates
 66.249.82.235 as permitted sender)
DomainKey-Status: good
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=P8tVWlmHAr21xECdOYL3QNx6zUimEGIZhriYiE4LOHpF7SaJAS8wDgruxKAk2TLLRsSt2H939Dgp19COz67v232A+TBe1+QdoZMNhIKjf+yc0/nqQkbCaXsWmcMQZ8rC28+9WpZwG2zQk3T2yCPaj4/LId7BItpElrwz87IcnQs=
Message-ID: <834b3bd50609270342t411c0c97m26bccf660724eddf@mail.gmail.com>
Date: Wed, 27 Sep 2006 14:42:31 +0400
From: "Denis Kishenko" <dkishenko@gmail.com>
To: harmony-dev@incubator.apache.org
Subject: Re: [jira] Is it comfortable for committers when source and test
 patches are packed in the single diff file?
In-Reply-To: <008401c6e1f5$bed512f0$0501a8c0@LITTLEGUY>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <45195505.60509@gmail.com>
	 <008401c6e1f5$bed512f0$0501a8c0@LITTLEGUY>

OK, thanks a lot.

P.S. I have found your discussion about separate patches.

2006/9/27, Nathan Beyer <nbeyer@kc.rr.com>:
>
> > -----Original Message-----
> > From: Tim Ellison [mailto:t.p.ellison@gmail.com]
> >
> > Geir Magnusson Jr. wrote:
> > >
> > > On Sep 26, 2006, at 10:23 AM, Denis Kishenko wrote:
> > >
> > >> Geir, thanks for answer.
> > >>
> > >> As I understand committers don't run tests from issue's descriptions?
> > >
> > > Sometimes.  But if a test can be provided, it makes things a lot easier
> > > on the committers, and improves chances of getting in.
> >
> > I agree -- and two patch files is just fine.
> >
> > Regards,
> > Tim
>
> I'll add another vote to two patch files. I do exactly what Geir said; apply
> the test patch, run the tests to see the failure, then apply the source
> patch to see how it fixes the issue.
>
> -Nathan
> >
> > >> 2006/9/26, Geir Magnusson Jr. <geir@pobox.com>:
> > >>> I really, really like two patches as we discussed on a different
> > thread.
> > >>>
> > >>> That way, I can apply the test patch, show the bug, apply the source
> > >>> patch, show it's gone (and then screw up and not commit all the code
> > >>> in the patch ;)
> > >>>
> > >>> Tim was neutral, but didn't care, so there's no opposition to asking
> > >>> for two.
> > >>>
> > >>> geir
> > >>>
> > >>> On Sep 26, 2006, at 9:29 AM, Denis Kishenko wrote:
> > >>>
> > >>> > Sometime I make two different diff files (source and test patches),
> > >>> > sometime I make the single one. Does it make sense for committers?
> > >>> >
> > >>> > --------------------------------------------------------------------
> > -
> > >>> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > >>> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > >>> > For additional commands, e-mail: harmony-dev-
> > help@incubator.apache.org
> > >>> >
> > >>>
> > >>>
> > >>> ---------------------------------------------------------------------
> > >>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> > >>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > >>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >>>
> > >>>
> > >>
> > >>
> > >> --Denis M. Kishenko
> > >> Intel Middleware Products Division
> > >>
> > >> ---------------------------------------------------------------------
> > >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> > >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >>
> > >
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> > --
> >
> > Tim Ellison (t.p.ellison@gmail.com)
> > IBM Java technology centre, UK.
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


-- 
Denis M. Kishenko
Intel Middleware Products Division

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org