Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Received-SPF: pass (asf.osuosl.org: domain of zhanghuangzhu@gmail.com
 designates 66.249.82.226 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=m4eYRul8Y6fPoHq9LwKPd9L4U8/ITOfW7Hc47s5NI17GwbnJ9wRTL4nPLTZVzgC/XpHUfQBCqXBhyAWHuKvh201KdHFw7pcahkliW25uv7E4SzmBtMEn0YJHj6p31UIXaFE/SnF1UQtQ3BaFUNYudzu+Q/0Uqfps4YaVouPhGII=
Message-ID: <4d0b24970609150624n35bdffddh71a50c43e0df7889@mail.gmail.com>
Date: Fri, 15 Sep 2006 21:24:29 +0800
From: "Andrew Zhang" <zhanghuangzhu@gmail.com>
To: harmony-dev@incubator.apache.org, geir@pobox.com
Subject: Re: [testing][beans] reverse engineering of RI
In-Reply-To: <450AA526.6080804@pobox.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_343985_24915468.1158326669827"
References: <2c9597b90609150556r359ddebv192ced44be6248a1@mail.gmail.com>
	 <450AA526.6080804@pobox.com>

------=_Part_343985_24915468.1158326669827
Content-Type: text/plain; charset=WINDOWS-1252; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On 9/15/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
>
>
>
> Alexei Zakharov wrote:
> > Hi all,
> >
> > While investigating one of the failed tests from the beans module
> > (PersistenceDelegateTest#*) I have discovered that the test is doing a
> > reverse engineering in fact. It passes some worm-like object to public
> > API method and then analyzes the calling stacktrace of each of its
> > methods by means of
> >
> > StackTraceElement[] eles =3D (new Throwable()).getStackTrace();
> > if (eles[i].getClassName().equals(=85) &&
> > eles[i].getMethodName().equals(..)) {=85}
> >
> > In that way, to enable this test we need to rewrite our code and make
> > it identical to RI's (at least in respect to the stack trace). Such
> > testing technique may be applied to many parts of Java API, not only
> > beans. Of course I can imagine some user application doing this but
> > such people should probably know what they do.
> >
> > Personally I don't like such methods of testing and vote for
> > refactoring of these tests. Other opinions? Thoughts?
>
> That's insane.  Does the Spec require a specific call sequence?


Maybe it wants to assert some methods are invoked. But the code is
unacceptable!

Sometimes, spec does point out or hint invoke one method would lead to
invoke another one.  But instead of these reverse engineering codes, using
mock subclass and invoke flag could be a solution.

geir
>
> >
> > Thanks,
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


--=20
Andrew Zhang
China Software Development Lab, IBM

------=_Part_343985_24915468.1158326669827--