Return-Path: Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org Received: (qmail 92456 invoked from network); 18 Sep 2006 16:21:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 18 Sep 2006 16:21:23 -0000 Received: (qmail 31229 invoked by uid 500); 18 Sep 2006 16:21:20 -0000 Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org Received: (qmail 31109 invoked by uid 500); 18 Sep 2006 16:21:19 -0000 Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-dev@incubator.apache.org Received: (qmail 31093 invoked by uid 99); 18 Sep 2006 16:21:19 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Sep 2006 09:21:19 -0700 X-ASF-Spam-Status: No, hits=1.4 required=10.0 tests=SPF_HELO_PASS,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: 216.86.168.178 is neither permitted nor denied by domain of geir@pobox.com) Received: from [216.86.168.178] (HELO mxout-03.mxes.net) (216.86.168.178) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Sep 2006 09:21:16 -0700 Received: from [10.109.220.35] (unknown [62.50.195.22]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.mxes.net (Postfix) with ESMTP id C484251927 for ; Mon, 18 Sep 2006 12:20:55 -0400 (EDT) Message-ID: <450EC768.8060307@pobox.com> Date: Mon, 18 Sep 2006 12:20:56 -0400 From: "Geir Magnusson Jr." Reply-To: geir@pobox.com User-Agent: Thunderbird 1.5.0.7 (Macintosh/20060909) MIME-Version: 1.0 To: harmony-dev@incubator.apache.org Subject: Re: [drlvm] is_name_lowercase() in natives_support.cpp References: <450ABF39.8060108@pobox.com> <187bb05d0609180910s59976c06lccfdc6499950492@mail.gmail.com> In-Reply-To: <187bb05d0609180910s59976c06lccfdc6499950492@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Artem Aliev wrote: > Geir, > > The current DRLVM build is still failed. Because I was waiting for Alexey :) I'll take your patch though. geir > I attach patch for the current state of VM. > Could you please apply it or commit new version of natives_support.cpp > > Thanks > Artem > > > On 9/18/06, Alexey Varlamov wrote: >> Geir, >> >> The DRLVM build is broken now on gcc3.3.3 (SUSE9): >> >> build.native.cpp: >> [cc] 135 total files to be compiled. >> [cc] drlvm/vm/vmcore/src/util/natives_support.cpp: In >> [cc] function `apr_dso_handle_t* natives_load_library(const > > ------------------------------------------------------------------------ > > Index: vm/vmcore/src/util/natives_support.cpp > =================================================================== > --- vm/vmcore/src/util/natives_support.cpp (revision 447423) > +++ vm/vmcore/src/util/natives_support.cpp (working copy) > @@ -203,7 +203,12 @@ > > char *localLibName = (char *) library_name; > NativeLibraryHandle returnCode = NULL; > - > + NativeLibInfo* pfound; > + NativeLibInfo* pinfo; > + NativeLibraryHandle handle; > + apr_status_t apr_status; > + Global_Env *ge; > + jint UNREF res; > #ifdef PLATFORM_NT > TRACE2("init", "### lib name = " << library_name); > > @@ -221,7 +226,7 @@ > > jni_libs.lock._lock(); > > - NativeLibInfo* pfound = search_library_list(localLibName); > + pfound = search_library_list(localLibName); > > if (pfound) > { > @@ -237,8 +242,7 @@ > *just_loaded = true; > > // library was not loaded previously, try to load it > - NativeLibraryHandle handle; > - apr_status_t apr_status = port_dso_load_ex(&handle, localLibName, > + apr_status = port_dso_load_ex(&handle, localLibName, > PORT_DSO_BIND_DEFER, jni_libs.ppool); > if (APR_SUCCESS != apr_status) > { > @@ -255,7 +259,7 @@ > goto NATIVES_LOAD_LIBRARY_EXIT; > } > > - NativeLibInfo* pinfo = (NativeLibInfo*)apr_palloc(jni_libs.ppool, sizeof(NativeLibInfo)); > + pinfo = (NativeLibInfo*)apr_palloc(jni_libs.ppool, sizeof(NativeLibInfo)); > if (NULL == pinfo) > { > apr_dso_unload(handle); > @@ -270,7 +274,7 @@ > > pinfo->handle = handle; > > - Global_Env *ge = VM_Global_State::loader_env; > + ge = VM_Global_State::loader_env; > pinfo->name = ge->string_pool.lookup(localLibName); > > pinfo->next = jni_libs.lib_info_list; > @@ -278,7 +282,7 @@ > > jni_libs.lock._unlock(); > > - jint UNREF res = find_call_JNI_OnLoad(pinfo->handle); // What to do with result??? > + res = find_call_JNI_OnLoad(pinfo->handle); // What to do with result??? > > *pstatus = APR_SUCCESS; > > > > ------------------------------------------------------------------------ > > --------------------------------------------------------------------- > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > For additional commands, e-mail: harmony-dev-help@incubator.apache.org --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org For additional commands, e-mail: harmony-dev-help@incubator.apache.org