Return-Path: Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org Received: (qmail 21706 invoked from network); 26 Sep 2006 13:41:11 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 26 Sep 2006 13:41:11 -0000 Received: (qmail 43746 invoked by uid 500); 26 Sep 2006 13:41:07 -0000 Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org Received: (qmail 43707 invoked by uid 500); 26 Sep 2006 13:41:07 -0000 Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-dev@incubator.apache.org Received: (qmail 43696 invoked by uid 99); 26 Sep 2006 13:41:07 -0000 Received: from idunn.apache.osuosl.org (HELO idunn.apache.osuosl.org) (140.211.166.84) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Sep 2006 06:41:07 -0700 Authentication-Results: idunn.apache.osuosl.org smtp.mail=geir@pobox.com; spf=unknown X-ASF-Spam-Status: No, hits=0.0 required=5.0 tests= Received-SPF: unknown (idunn.apache.osuosl.org: domain pobox.com does not designate 216.86.168.179 as permitted sender) Received: from [216.86.168.179] ([216.86.168.179:3094] helo=mxout-04.mxes.net) by idunn.apache.osuosl.org (ecelerity 2.1.1.8 r(12930)) with ESMTP id B6/90-11437-0FD29154 for ; Tue, 26 Sep 2006 06:41:06 -0700 Received: from [10.1.189.131] (unknown [72.254.23.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by smtp.mxes.net (Postfix) with ESMTP id F189FA32E9 for ; Tue, 26 Sep 2006 09:41:01 -0400 (EDT) Mime-Version: 1.0 (Apple Message framework v752.2) In-Reply-To: <834b3bd50609260629u519f233du6bb2f3c8bd62acd@mail.gmail.com> References: <834b3bd50609260629u519f233du6bb2f3c8bd62acd@mail.gmail.com> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <21775D26-F7D0-4918-9A78-C132CE4FA437@pobox.com> Content-Transfer-Encoding: 7bit From: "Geir Magnusson Jr." Subject: Re: [jira] Is it comfortable for committers when source and test patches are packed in the single diff file? Date: Tue, 26 Sep 2006 09:41:02 -0400 To: harmony-dev@incubator.apache.org X-Mailer: Apple Mail (2.752.2) X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N I really, really like two patches as we discussed on a different thread. That way, I can apply the test patch, show the bug, apply the source patch, show it's gone (and then screw up and not commit all the code in the patch ;) Tim was neutral, but didn't care, so there's no opposition to asking for two. geir On Sep 26, 2006, at 9:29 AM, Denis Kishenko wrote: > Sometime I make two different diff files (source and test patches), > sometime I make the single one. Does it make sense for committers? > > --------------------------------------------------------------------- > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org > For additional commands, e-mail: harmony-dev-help@incubator.apache.org > --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org For additional commands, e-mail: harmony-dev-help@incubator.apache.org