Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Received-SPF: pass (idunn.apache.osuosl.org: domain gmail.com designates
 66.249.82.232 as permitted sender)
DomainKey-Status: good
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=myINs5JR1RtcAMqbWf8jHV66JBxTKoD3v/gMkl8si7tEIxigBb3jofKbrUSUu0WP0qRO0X3PxNNgZpR/EpQ+9+TEdnaFZAN/0bQrVfNFlAYI33fyL/HWFmbLzJinmyIVJ/ON7RMtZwn+Yhh1dOh4ih85UvWg919efS0bfzW0M50=
Message-ID: <211709bc0609122129r1e49c8a7qad6f27095e7b0337@mail.gmail.com>
Date: Wed, 13 Sep 2006 12:29:41 +0800
From: "Tony Wu" <wuyuehao@gmail.com>
To: harmony-dev@incubator.apache.org
Subject: Re: [classlib]volunteer to supply patches for old JIRAs
In-Reply-To: <006c01c6d6e9$7b5c7a20$0401a8c0@LITTLEGUY>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_222761_31894994.1158121781674"
References: <211709bc0609122026i238af5a7q9ac6357b7b995cec@mail.gmail.com>
	 <006c01c6d6e9$7b5c7a20$0401a8c0@LITTLEGUY>

------=_Part_222761_31894994.1158121781674
Content-Type: text/plain; charset=ISO-2022-JP; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

so helpful suggestion, thank you Nathan.
According to Nathan's suggestion, I suggest we go ahead as below,
1. verify all the issues without patch, supply a patch if possible.
2. for the issues already has a patch, verify the reason why it was ignored,
and then
a.write testcase if caused by lack of test.
b.supply another patch if the patch is out of date.
c.add comments to support it if the patch is ok.


On 9/13/06, Nathan Beyer <nbeyer@kc.rr.com> wrote:
>
> Here are a few things that I think might help with getting through some of
> the older outstanding issues, as well as new ones.
>
> * If an issue is old (over a month???), then verify that it's still an
> issue
> with the latest code and note this with a JIRA comment.
> * Obviously posting patches is great, but patches without tests are almost
> always ignored.
> ** If you're posting an enhancement, post a patch that enhances the tests
> and make sure they pass on an RI. (I always make sure the test passes on
> the
> RI before considering the patch.)
> ** If you're posting a fix, post a patch that includes a regression test.
> (I
> always apply the test first, then run it to see it fail, then I look at
> the
> fix.)
> * If there's a particular JIRA issue that you would like fixed and a patch
> already exists, try applying the patch yourself, verify it and then add a
> comment supporting the patch.
>
>
> -Nathan
>
> > -----Original Message-----
> > From: Tony Wu [mailto:wuyuehao@gmail.com]
> > Sent: Tuesday, September 12, 2006 10:26 PM
> > To: harmony-dev@incubator.apache.org
> > Subject: Re: [classlib]volunteer to supply patches for old JIRAs
> >
> > On 9/13/06, Spark Shen <smallsmallorgan@gmail.com> wrote:
> > >
> > > Tony Wu 写道:
> > > > Hi all,
> > > > I noticed there're many unresolved JIRAs posted so long time. I
> > > > purpose to
> > > > dive into and find whether it is in my range and try to supply a
> patch
> > > > if no
> > > > one objects :)
> > > > Is there anyone alse has interest and would like to work with me?
> > > >
> > > Hi,
> > > It is interesting of your proposal. May I join in?
> >
> >
> > Great! Welcome!
> >
> > I noticed that there are many categories of components. I suggest we
> > > only deal with those components we are familier with.
> > > Since there are so many unresolved JIRAs, will you start from the
> > > beginning and I will start from the end. If someone else is
> interested,
> > > he/she may start from the middle. :-)
> >
> >
> > good idea, I'll start to look in descendent order of jira sn.
> >
> >
> > Best regards
> > >
> > > --
> > > Spark Shen
> > > China Software Development Lab, IBM
> > >
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> >
> > --
> > Tony Wu
> > China Software Development Lab, IBM
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


-- 
Tony Wu
China Software Development Lab, IBM

------=_Part_222761_31894994.1158121781674--