harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov" <alexey.v.varla...@gmail.com>
Subject Re: [drlvm] is_name_lowercase() in natives_support.cpp
Date Mon, 18 Sep 2006 09:08:10 GMT
Geir,

The DRLVM build is broken now on gcc3.3.3 (SUSE9):

build.native.cpp:
       [cc] 135 total files to be compiled.
       [cc] drlvm/vm/vmcore/src/util/natives_support.cpp: In
       [cc]    function `apr_dso_handle_t* natives_load_library(const
char*, bool*,
       [cc]    NativeLoadStatus*)':
       [cc] drlvm/vm/vmcore/src/util/natives_support.cpp:287: error: jump
       [cc]    to label `NATIVES_LOAD_LIBRARY_EXIT'
       [cc] drlvm/vm/vmcore/src/util/natives_support.cpp:268: error:
       [cc]     from here
       [cc] drlvm/vm/vmcore/src/util/natives_support.cpp:281: error:
       [cc]     crosses initialization of `jint res'
       [cc] drlvm/vm/vmcore/src/util/natives_support.cpp:273: error:
       [cc]     crosses initialization of `Global_Env*ge'
       [cc] drlvm/vm/vmcore/src/util/natives_support.cpp:287: error: jump
       [cc]    to label `NATIVES_LOAD_LIBRARY_EXIT'
       [cc] drlvm/vm/vmcore/src/util/natives_support.cpp:255: error:
       [cc]     from here
       [cc] drlvm/vm/vmcore/src/util/natives_support.cpp:281: error:
       [cc]     crosses initialization of `jint res'
       [cc] drlvm/vm/vmcore/src/util/natives_support.cpp:273: error:
       [cc]     crosses initialization of `Global_Env*ge'
       [cc] drlvm/vm/vmcore/src/util/natives_support.cpp:258: error:
       [cc]     crosses initialization of `NativeLibInfo*pinfo'
       [cc] drlvm/vm/vmcore/src/util/natives_support.cpp:287: error: jump
       [cc]    to label `NATIVES_LOAD_LIBRARY_EXIT'
       [cc] drlvm/vm/vmcore/src/util/natives_support.cpp:234: error:
       [cc]     from here
       [cc] drlvm/vm/vmcore/src/util/natives_support.cpp:281: error:
       [cc]     crosses initialization of `jint res'
       [cc] drlvm/vm/vmcore/src/util/natives_support.cpp:273: error:
       [cc]     crosses initialization of `Global_Env*ge'
       [cc] drlvm/vm/vmcore/src/util/natives_support.cpp:258: error:
       [cc]     crosses initialization of `NativeLibInfo*pinfo'
       [cc] drlvm/vm/vmcore/src/util/natives_support.cpp:241: error:
       [cc]     crosses initialization of `apr_status_t apr_status'

BUILD FAILED

Besides, you introduced inconsistency in names, ones registered inside
of ClassLoader::LoadNativeLibrary and those actually loaded in
natives_load_library().
So, if one will try loading the same lib with different names on
Windows via j.l.System.loadLibrary(), there will be unexpected
UnsatisfiedLinkError.
I guess that awkward usage of port_filepath_canonical() was intended
to solve exactly this problem.

So we still need better solution.

--
Alexey

2006/9/15, Geir Magnusson Jr. <geir@pobox.com>:
> Looking at things, yes, it's the ICU dll, which has uppercase letters in
> the filename.
>
> My plan is to just convert all paths to lowercase.
>
> Any problems people can see?
>
> geir
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message