harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov" <alexey.v.varla...@gmail.com>
Subject Re: [classlib] [ldap] support for multiple VMs?
Date Mon, 04 Sep 2006 14:34:19 GMT
2006/8/28, Paulex Yang <paulex.yang@gmail.com>:
> Oliver Deakin wrote:
> > Hi Alexey,
> >
> > I have taken a look at the patch - generally it looks good to me, and
> > if it all
> > works ok when you test it, it's fine by me.
> >
> > I think if there are cases where some functionality is repeated many
> > times, it
> > would be good to see it split out somewhere central. However, Im not sure
> > the port library is the right place for these functions - the port
> > library is really a
> > generic front hiding platform specific operations. These functions do
> > not really
> > fit into that category - perhaps they would be better placed in the
> > common
> > library (luni/src/main/native/common)? This component provides a set of
> > helper functions required by many native modules, and seems like the
> > right
> > place to put them.
> Agree, portlib is designed to encapsulate OS/architecture difference,
> and it should be taken care to be concise, so that it can be ported
> easily to as many platforms as possible(at least to those Harmony
> planned to support),  it is not a common library.

Paulex, Oliver,

Sorry for late response, I fully agree with your considerations. I was
just not familiar enough with luni natives structure and was drawn
away with idea of runtime code sharing. But indeed common lib with
static linkage is appropriate for the case.
So I rearranged the patch for HARMONY-1243, please review and commit.
Seems there are good cases for using these common functions, for
example issue #1386.

--
WBR,
Alexey

> >
> > Regards,
> > Oliver
> >
> > Alexey Varlamov wrote:
> >> Oliver,
> >>
> >> Please take a look at a HARMONY-1243 patch. I fixed all bugs noticed
> >> and made parsing a bit more robust. Also, added a define for
> >> "org.apache.harmony.boot.class.path" name to vmi.h - to enforce that
> >> there is 2-sided contract for this property.
> >>
> >> I still think that some of those functions may worth to be added to
> >> the portlib, namely:
> >> char * str_concat (HyPortLibrary * portLibrary, ...);
> >> int props_read_from_file(HyPortLibrary * portLibrary, const char
> >> *filename,
> >>                          key_value_pair** properties, U_32 *number);
> >> void props_free(HyPortLibrary * portLibrary, key_value_pair *
> >> properties);
> >>
> >> Justification: the same functionality is duplicated at least in
> >> launcher/shared/main.c, and there are other property files to be read
> >> by VM.
> >>
> >> If nobody object, I will try to add these 3 functions to portlib.
> >>
> >
>
>
> --
> Paulex Yang
> China Software Development Lab
> IBM
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message