harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elena Semukhina" <elena.semukh...@gmail.com>
Subject Re: [DRLVM] Thread Manager jvmti related issues fixes (was: Re: [jira] Commented: (HARMONY-1421))
Date Fri, 22 Sep 2006 08:54:42 GMT
On 9/21/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
>
>
> On Sep 21, 2006, at 6:48 AM, Elena Semukhina wrote:
>
> > On 9/21/06, Vladimir Gorr <vvgorr@gmail.com> wrote:
> >>
> >> On 9/21/06, Elena Semukhina <elena.semukhina@gmail.com> wrote:
> >> >
> >> > Looking at ThreadTest failures I see that all 1421-related failures
> >> > disappear. But there are 3 new failures which I've never seen
> >> before.
> >> Two
> >> > of
> >> > them actually relate to "using the launcher" problems,
> >>
> >>
> >> Is it possible to give more details about this or to file new JIRA
> >> issue?
> >
> >
> > These tests reveal that the main thread's name and thread group
> > hierarchy
> > have been changed with the launcher implementation.
>
> But that will be the case anytime in general right?  You can't assume
> what is creating and invoking the VM.


You are right in general but in particular we are testing drlvm now and it
is desirable that our tests pass on some other VMs (Sun, BEA, IBM) as well
and nothing more for today :)
The test that checks the name of the main thread is not as useless as it
looks at first glance. At least, it helps to reveal that something has been
changed and stimulates to look thouroughly into that :)

So looking thouroughly into the changes I discovered that the thread group
hierarchy has been changed. Previously we had the "system" thread group at
the top (which parent is null) containing the subgroup "main" where the main
thread was created. This hierarchy is not specified explicitly but is
assumed. Otherwise any thread created by main thread in its thread group
becomes a "system thread", which is not our intention but drlvm works this
way now. E.g. the following test passes on the above mentioned VMs and fails
on drlvm now with AccessControlException at t.checkAccess(), which is
undoubtely unexpected behavior. The good news is that Evgueni is going to
restore the "main" thread group.

public class ThreadSecurityManager {
    public static void main(String[] args) {
        Thread t = new Thread();
        if (t.getThreadGroup().getParent() == null) {
            System.out.println("created in the system thread group");
        }
        System.setSecurityManager(new SecurityManager());
        t.checkAccess();
        System.out.println("Passed");
    }
}
Thanks,
Elena


> > As Evgueni said that he
> > worked on Invocation API [1], I asked him to run these tests in his
> > environment and they passed.
> > So we should wait until his changes are approved and committed.
> >
> > [1]
> > http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/
> > 200609.mbox/%
> > 3ce29119980609210001o59b2f252s85e4b8d451a80ff6@mail.gmail.com%3e
> >
> > Thanks,
> > Elena
> >
> > Thanks,
> >> Vladimir.
> >>
> >> but the third one deserves a special investigation.
> >> >
> >> > The problem is that Thread.currentThread().isAlive() returns
> >> false now.
> >> > Can
> >> > anyone comment on this?
> >> >
> >> > Thanks,
> >> > Elena
> >> >
> >> > On 9/21/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
> >> > >
> >> > > I'm not paying much attention to the kernel tests these days
> >> while we
> >> > > sort out the main problems.
> >> > >
> >> > > I do think that once we sort out the "using the launcher"
> >> problems,
> >> > > and get the patch backlog applied, we really should go after
> >> all of
> >> > > these broken tests
> >> > >
> >> > > We also need to refractor the test framework so including/
> >> excluding a
> >> > > test doesn't require changing the test source code...
> >> > >
> >> > > geir
> >> > >
> >> > > On Sep 20, 2006, at 7:22 PM, Weldon Washburn wrote:
> >> > >
> >> > > > On 9/20/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
> >> > > >>
> >> > > >> patch applied, JIRA closed
> >> > > >
> >> > > >
> >> > > > Good.  I was just about to suggest the very same thing.  I
> >> applied
> >> > > > both of
> >> > > > the 1421 patches and a substantial number of tests now run on
> >> > > > windows.  At
> >> > > > this time I see only the below test failures.  I commented out
> >> > > > gc.LOS test
> >> > > > because it still hangs.
> >> > > >
> >> > > >
> >> > > >    [junit] Test java.lang.ThreadGroupTest FAILED
> >> > > >    [junit] Test java.lang.ThreadGroupTest FAILED
> >> > > >     [echo]    **** FAILED on reference JRE ****
> >> > > >    [junit] Test java.lang.ThreadTest FAILED
> >> > > >    [junit] Test java.lang.ThreadTest FAILED
> >> > > >     [echo]    **** FAILED on reference JRE ****
> >> > > >     [echo] Kernel tests FAILED using jitrino.jet. Please
> >> find the
> >> > > > detailed
> >> > > > resu
> >> > > >
> >> > > >    [junit] Test java.lang.ClassAnnotationsTest FAILED
> >> > > >    [junit] Test java.lang.ClassAnnotationsTest FAILED
> >> > > >     [echo]    **** FAILED on reference JRE ****
> >> > > >    [junit] Test java.lang.ClassLoaderTest FAILED
> >> > > >    [junit] Test java.lang.ClassLoaderTest FAILED
> >> > > >     [echo]    **** FAILED on reference JRE ****
> >> > > >    [junit] Test java.lang.ThreadGroupTest FAILED
> >> > > >    [junit] Test java.lang.ThreadGroupTest FAILED
> >> > > >     [echo]    **** FAILED on reference JRE ****
> >> > > >    [junit] Test java.lang.ThreadTest FAILED
> >> > > >    [junit] Test java.lang.ThreadTest FAILED
> >> > > >     [echo]    **** FAILED on reference JRE ****
> >> > > >     [echo] Kernel tests FAILED using jitrino.opt. Please
> >> find the
> >> > > > detailed
> >> > > > resu
> >> > > >
> >> > > >    [junit] Test java.lang.ClassGenericsTest FAILED (timeout)
> >> > > >    [junit] Test java.lang.ClassGenericsTest FAILED
> >> > > >     [echo]    **** FAILED on reference JRE ****
> >> > > >    [junit] Test java.lang.ThreadGroupTest FAILED
> >> > > >    [junit] Test java.lang.ThreadGroupTest FAILED
> >> > > >     [echo]    **** FAILED on reference JRE ****
> >> > > >    [junit] Test java.lang.ThreadTest FAILED
> >> > > >    [junit] Test java.lang.ThreadTest FAILED
> >> > > >     [echo]    **** FAILED on reference JRE ****
> >> > > >     [echo] Kernel tests FAILED using interpreter. Please
> >> find the
> >> > > > detailed
> >> > > > resu
> >> > > >
> >> > > > geir
> >> > > >
> >> > > >
> >> > > > --
> >> > > > Weldon Washburn
> >> > > > Intel Middleware Products Division
> >> > >
> >> > >
> >> > >
> >> ---------------------------------------------------------------------
> >> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> > > To unsubscribe, e-mail: harmony-dev-
> >> unsubscribe@incubator.apache.org
> >> > > For additional commands, e-mail: harmony-dev-
> >> help@incubator.apache.org
> >> > >
> >> > >
> >> >
> >> >
> >> > --
> >> > Thanks,
> >> > Elena
> >> >
> >> >
> >>
> >>
> >
> >
> > --
> > Thanks,
> > Elena
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


-- 
Thanks,
Elena

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message