harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leo Li" <liyilei1...@gmail.com>
Subject Re: [classlib][build] failure?
Date Wed, 20 Sep 2006 02:03:17 GMT
Hi, all:

Since I am not an expert of gcc, I think we need a guru to set the flags in
makefile of linux:
1. It will report any required warnings and regard it as error to lead a
failure build so that it is forced for us to correct it.

2. It can avoid to stop building due to such warnings:

In OSFileSystem.c, we have:
JNIEXPORT jlong JNICALL
Java_org_apache_harmony_luni_platform_OSFileSystem_readDirectImpl
  (JNIEnv * env, jobject thiz, jlong fd, jlong buf, jint offset, jint
nbytes)
{
  PORT_ACCESS_FROM_ENV (env);
  return (jlong) hyfile_read ((IDATA) fd, (void *) (buf+offset), (IDATA)
nbytes);
}
Actually, the hyfile_read returns a int32 while the jlong is int64. I think
the warning seems to be not avoidable.

I have had tried some flags, but I have not got what I want.
Any good suggestion?




On 9/19/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
>
> Really - I think the explanation was totally reasonable.  I didn't
> understand before why it was asymmetric.
>
> On Sep 19, 2006, at 8:40 AM, Mark Hindess wrote:
>
> >
> > Well, I was just pointing out a further inconsistency (awt/
> > windows).  I
> > don't recall when/why linux errors were downgraded so that might have
> > happened before I started hacking the natives around.
> >
> > Regards,
> >  Mark.
> >
> > On 19 September 2006 at 7:10, "Geir Magnusson Jr." <geir@pobox.com>
> > wrote:
> >> Ok, good - there's a totally reasonable explanation :)
> >>
> >> geir
> >>
> >> On Sep 19, 2006, at 7:05 AM, Mark Hindess wrote:
> >>
> >>>
> >>> Incidentally, I had to override the default windows flags to turn
> >>> off
> >>> the warnings-as-error for the awt native code in order to integrate
> >>> it.
> >>> I mentioned this on the -dev list at the time hoping to see some
> >>> patches
> >>> to fix the issues but there haven't been any as yet.
> >>>
> >>> I agree it would be a good thing to fix for all the native code on
> >>> both
> >>> platforms.
> >>>
> >>> Regards,
> >>>  Mark.
> >>>
> >>> On 19 September 2006 at 4:46, "Geir Magnusson Jr." <geir@pobox.com>
> >>> wrote:
> >>>> There is no way to get rid of the warnings in our codebase on
> >>>> linux?
> >>>>
> >>>> geir
> >>>>
> >>>> On Sep 19, 2006, at 4:03 AM, Leo Li wrote:
> >>>>
> >>>>> Hi, Geir:
> >>>>>  The warning level is set to level 3 while the warning as error
> >>>>> option is
> >>>>> off in linux.
> >>>>>  Actually, I would like to set it on in linux since it will
> >>>>> help me
> >>>>> to pick
> >>>>> some error out, for example, wrongly use pointers. However, I have
> >>>>> tried to
> >>>>> set it on, but some unavoidable warning will lead to a failure in
> >>>>> Harmony
> >>>>> building. Any good idea?:)
> >>>>>
> >>>>> Good luck!
> >>>>>
> >>>>> On 9/19/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
> >>>>>>
> >>>>>> Lets get these aligned...  I tend to work on linux, so it had
no
> >>>>>> problem building..
> >>>>>>
> >>>>>> geir
> >>>>>>
> >>>>>> On Sep 18, 2006, at 10:14 PM, Leo Li wrote:
> >>>>>>
> >>>>>>> Just comment it out since it is just a warning treated as
error.
> >>>>>>> It compiles successfully and runs well.
> >>>>>>> Maybe it will not lead to such an error on Linux due to
the
> >>>>>>> configuration of
> >>>>>>> make rules.:)
> >>>>>>>
> >>>>>>> Good luck!
> >>>>>>>
> >>>>>>>
> >>>>>>> On 9/19/06, Spark Shen <smallsmallorgan@gmail.com>
wrote:
> >>>>>>>>
> >>>>>>>> Hi All:
> >>>>>>>> When building today's(Sep 19, r447671) classlib on window
xp, I
> >>>>>>>> got the
> >>>>>>>> following error message:
> >>>>>>>>     [exec] main.c
> >>>>>>>>     [exec] ..\shared\main.c(628) : error C2220: warning
> >>>>>>>> treated as
> >>>>>>>> error - no o
> >>>>>>>> bject file generated
> >>>>>>>>     [exec] ..\shared\main.c(628) : warning C4101: 'jarRunner'
:
> >>>>>>>> unreferenced lo
> >>>>>>>> cal variable
> >>>>>>>>     [exec] NMAKE : fatal error U1077: 'cl' : return
code '0x2'
> >>>>>>>>     [exec] Stop.
> >>>>>>>>     [exec] NMAKE : fatal error U1077: '"c:\Program Files
> >>>>>>>> \Microsoft
> >>>>>>>> Visual Studi
> >>>>>>>> o .NET 2003\VC7\BIN\nmake.exe"' : return code '0x2'
> >>>>>>>>     [exec] Stop.
> >>>>>>>>
> >>>>>>>> BUILD FAILED
> >>>>>>>> C:\spark\harmony\build.xml:95: The following error occurred
> >>>>>>>> while
> >>>>>>>> executing this
> >>>>>>>> line:
> >>>>>>>> C:\spark\harmony\make\build-native.xml:75: The following
error
> >>>>>>>> occurred
> >>>>>>>> while ex
> >>>>>>>> ecuting this line:
> >>>>>>>> C:\spark\harmony\modules\luni\build.xml:167: The following
> >>>>>>>> error
> >>>>>>>> occurred while
> >>>>>>>> executing this line:
> >>>>>>>> C:\spark\harmony\make\properties.xml:258: exec returned:
2
> >>>>>>>>
> >>>>>>>> Could any one check it?
> >>>>>>>>
> >>>>>>>> Best regards
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>> Spark Shen
> >>>>>>>> China Software Development Lab, IBM
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>> -----------------------------------------------------------------
> >>>>>> --
> >>>>>> --
> >>>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>>>>>>> To unsubscribe, e-mail: harmony-dev-
> >>>>>> unsubscribe@incubator.apache.org
> >>>>>>>> For additional commands, e-mail: harmony-dev-
> >>>>>>>> help@incubator.apache.org
> >>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> --
> >>>>>>> Leo Li
> >>>>>>> China Software Development Lab, IBM
> >>>>>>
> >>>>>>
> >>>>>> -----------------------------------------------------------------
> >>>>>> --
> >>>>>> --
> >>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>>>>> To unsubscribe, e-mail: harmony-dev-
> >>>>>> unsubscribe@incubator.apache.org
> >>>>>> For additional commands, e-mail: harmony-dev-
> >>>>>> help@incubator.apache.org
> >>>>>>
> >>>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>> Leo Li
> >>>>> China Software Development Lab, IBM
> >>>>
> >>>>
> >>>> -------------------------------------------------------------------
> >>>> --
> >>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>>> To unsubscribe, e-mail: harmony-dev-
> >>>> unsubscribe@incubator.apache.org
> >>>> For additional commands, e-mail: harmony-dev-
> >>>> help@incubator.apache.org
> >>>>
> >>>
> >>>
> >>>
> >>> --------------------------------------------------------------------
> >>> -
> >>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >>> For additional commands, e-mail: harmony-dev-
> >>> help@incubator.apache.org
> >>>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: harmony-dev-
> >> help@incubator.apache.org
> >>
> >
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


-- 
Leo Li
China Software Development Lab, IBM

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message