harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Kleymenov" <kleyme...@gmail.com>
Subject Re: [jira] Updated: (HARMONY-1370) [classlib][luni] HttpsURLConnection enhancement allowing work over HTTP proxy server
Date Mon, 18 Sep 2006 05:41:07 GMT
Hello Mikhail,

On 9/14/06, Mikhail Loenko <mloenko@gmail.com> wrote:
> It seams like system property are not restored well, new 1.5 method
> System.clearProperty() IMHO would be suitable
> What do you think?

You are right! If setProperty(property) returned null, we should
restore overridden property by clearProperty.

I'll fix it and provide as a new patch for H-1370.

>
> I still have a question.
>
> As we've discussed [1] available method can be trusted in very special
> cases only.
>
> So, should this code
>                while (is.available() != 0) {
>                    is.read();
>                }
> be replaced with reading until '-1'?
>

Here is no need to reach -1. If we will do so the implementation will
hang up. What is needed here is just read trailing data from the
stream (if any) before starting of SSL handshake process (over 'is').
In case of keeping data in the stream the handshake will fail and user
will get an exception.

Thank You,
Alexander

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message