harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Petrenko" <alexey.a.petre...@gmail.com>
Subject Re: [jira] Created: (HARMONY-1505) [build?] Some of the Harmony jni libraries has wrong function names inside
Date Wed, 27 Sep 2006 11:37:39 GMT
MS VC documentation recommends to use "__declspec(dllexport)" option
instead of EXPORTS section. In our case it is JNIEXPORT.
And all of the JNI functions are marked as JNIEXPORT.

2006/9/27, Mark Hindess <mark.hindess@googlemail.com>:
>
> On 27 September 2006 at 15:18, "Alexey Petrenko" <alexey.a.petrenko@gmail.com>
wrote:
> > So... If there is now EXPORTS section advocates I will prepare a patch
> > to remove them from the def files for Windows.
>
> If removing them means we are exporting all symbols, then I'd rather
> keep explicit exports of the symbols we intend to be public.
>
> Is there no way to fix it and keep the explicit list of "public"
> symbols?
>
> -Mark.
>
> > SY, Alexey
> >
> > 2006/9/26, Alexey Petrenko <alexey.a.petrenko@gmail.com>:
> > > Guys,
> > >
> > > investigation shown that if we remove EXPORTS section from the def
> > > file then the result dll has correct names.
> > >
> > > Is there any objections on removing EXPORTS sections from the def
> > > files on Windows?
> > >
> > > SY, Alexey
> > >
> > > 2006/9/20, Alexey Petrenko (JIRA) <jira@apache.org>:
> > > > [build?] Some of the Harmony jni libraries has wrong function names insid
> > e
> > > > -------------------------------------------------------------------------
> > -
> > > >
> > > >                 Key: HARMONY-1505
> > > >                 URL: http://issues.apache.org/jira/browse/HARMONY-1505
> > > >             Project: Harmony
> > > >          Issue Type: Bug
> > > >          Components: Classlib
> > > >         Environment: Windows
> > > >            Reporter: Alexey Petrenko
> > > >
> > > >
> > > > Some of the Harmony jni libraries, for example hyluni.dll, has function
n
> > ames which are not prefixed by underscore ( _ ).
> > > >
> > > > JNI spec says that all the JNI methods on Windows should be declared as
_
> > _stdcall. [1] And MS C documentation says that __stdcall function names shoul
> > d be prefixed by underscore. [2]
> > > >
> > > > [1] http://java.sun.com/j2se/1.5.0/docs/guide/jni/spec/design.html#wp615
> > > > [2] http://msdn2.microsoft.com/en-us/library/zxk0tw93.aspx
> > > >
> > > > --
> > > > This message is automatically generated by JIRA.
> > > > -
> > > > If you think it was sent incorrectly contact one of the administrators:
h
> > ttp://issues.apache.org/jira/secure/Administrators.jspa
> > > > -
> > > > For more information on JIRA, see: http://www.atlassian.com/software/jira
> > > >
> > > >
> > > >
> > >
> > >
> > > --
> > > Alexey A. Petrenko
> > > Intel Middleware Products Division
> > >
> >
> >
> > --
> > Alexey A. Petrenko
> > Intel Middleware Products Division
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


-- 
Alexey A. Petrenko
Intel Middleware Products Division

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message