harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Petrenko" <alexey.a.petre...@gmail.com>
Subject Re: [classlib]volunteer to supply patches for old JIRAs
Date Wed, 13 Sep 2006 05:15:24 GMT
I'll take part in this too. As far as I remember not all of my fixes
has patches for test... Seems it is a good time to fix this :)

SY, Alexey

2006/9/13, Tony Wu <wuyuehao@gmail.com>:
> so helpful suggestion, thank you Nathan.
> According to Nathan's suggestion, I suggest we go ahead as below,
> 1. verify all the issues without patch, supply a patch if possible.
> 2. for the issues already has a patch, verify the reason why it was ignored,
> and then
> a.write testcase if caused by lack of test.
> b.supply another patch if the patch is out of date.
> c.add comments to support it if the patch is ok.
>
>
> On 9/13/06, Nathan Beyer <nbeyer@kc.rr.com> wrote:
> >
> > Here are a few things that I think might help with getting through some of
> > the older outstanding issues, as well as new ones.
> >
> > * If an issue is old (over a month???), then verify that it's still an
> > issue
> > with the latest code and note this with a JIRA comment.
> > * Obviously posting patches is great, but patches without tests are almost
> > always ignored.
> > ** If you're posting an enhancement, post a patch that enhances the tests
> > and make sure they pass on an RI. (I always make sure the test passes on
> > the
> > RI before considering the patch.)
> > ** If you're posting a fix, post a patch that includes a regression test.
> > (I
> > always apply the test first, then run it to see it fail, then I look at
> > the
> > fix.)
> > * If there's a particular JIRA issue that you would like fixed and a patch
> > already exists, try applying the patch yourself, verify it and then add a
> > comment supporting the patch.
> >
> >
> > -Nathan
> >
> > > -----Original Message-----
> > > From: Tony Wu [mailto:wuyuehao@gmail.com]
> > > Sent: Tuesday, September 12, 2006 10:26 PM
> > > To: harmony-dev@incubator.apache.org
> > > Subject: Re: [classlib]volunteer to supply patches for old JIRAs
> > >
> > > On 9/13/06, Spark Shen <smallsmallorgan@gmail.com> wrote:
> > > >
> > > > Tony Wu 写道:
> > > > > Hi all,
> > > > > I noticed there're many unresolved JIRAs posted so long time. I
> > > > > purpose to
> > > > > dive into and find whether it is in my range and try to supply a
> > patch
> > > > > if no
> > > > > one objects :)
> > > > > Is there anyone alse has interest and would like to work with me?
> > > > >
> > > > Hi,
> > > > It is interesting of your proposal. May I join in?
> > >
> > >
> > > Great! Welcome!
> > >
> > > I noticed that there are many categories of components. I suggest we
> > > > only deal with those components we are familier with.
> > > > Since there are so many unresolved JIRAs, will you start from the
> > > > beginning and I will start from the end. If someone else is
> > interested,
> > > > he/she may start from the middle. :-)
> > >
> > >
> > > good idea, I'll start to look in descendent order of jira sn.
> > >
> > >
> > > Best regards
> > > >
> > > > --
> > > > Spark Shen
> > > > China Software Development Lab, IBM
> > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > > >
> > > >
> > >
> > >
> > > --
> > > Tony Wu
> > > China Software Development Lab, IBM
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> Tony Wu
> China Software Development Lab, IBM
>
>


-- 
Alexey A. Petrenko
Intel Middleware Products Division
Mime
View raw message