harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geir Magnusson Jr." <g...@pobox.com>
Subject Re: [drlvm] my latest round of patches broke something
Date Tue, 26 Sep 2006 05:42:03 GMT

On Sep 26, 2006, at 12:25 AM, Vladimir Gorr wrote:

> On 9/25/06, Geir Magnusson Jr <geir@pobox.com> wrote:
>>
>>
>>
>> Vladimir Gorr wrote:
>> > On 9/25/06, Vladimir Gorr <vvgorr@gmail.com> wrote:
>> >>
>> >>
>> >>
>> >> On 9/25/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
>> >> >
>> >> > Under what platfrom, what build?
>> >>
>> >>
>> >> On Windows for build I've built from the latest sources (at 449592
>> >> revision).
>> >>
>> >
>> > Sorry I was mistaken :-(. JAVA_HOME refers to RI and therefore all
>> works.
>>
>> So just to make this perfectly clear :
>>
>> 1) the code in SVN is ok
>
>
> What about *patches/win/APR/threadproc/win32/thread.c* file?
>

Done

> 2) the problem was because JAVA_HOME was pointing to the RI
>
>
> Absolutely.
>
>
> 3) we should ignore the patch you inlined in the message before  
> this one
>
>
> I'm not sure. This patch eliminates a lot of test failures as I  
> mentioned
> before (BTW you also commented on same issue into H-1457).
> Do we want to live with this? And one more note is our patch is not  
> related
> with eliminating the ActiveMQ crash. It's another story.

I wasn't arguing, I was trying to figure out what you were saying,  
because it seemed like once you did a clean rebuild, all was ok.  Now  
I'll assume that all was *not* ok.  I just added thread.c.  My fault  
- I overlooked it.  Sorry.

>
> Thanks,
> Vladimir.
>
> geir
>>
>> >
>> > Thanks,
>> > Vladimir.
>> >
>> > Thanks,
>> >> Vladimir.
>> >>
>> >> On Sep 25, 2006, at 5:50 AM, Vladimir Gorr wrote:
>> >> >
>> >> > > BTW I've forgot to say ActiveMQ 4.0 works w/o any problems.
>> >> > >
>> >> > > Thanks,
>> >> > > Vladimir.
>> >> > >
>> >> > > On 9/25/06, Vladimir Gorr <vvgorr@gmail.com> wrote:
>> >> > >>
>> >> > >> As for me (and other people) a lot of tests fail for the 

>> latest
>> >> > >> sources
>> >> > >> (revision 449592).
>> >> > >> I've run the *build.bat clean; build.bat update; build.bat*
>> >> > >> command in
>> >> > >> compliance with comments for *H-1457*.
>> >> > >> It's very strange for me it mentions here all C-unit tests
 
>> work
>> >> fine.
>> >> >
>> >> > >> Sorry I cannot confirm this.
>> >> > >> The detailed investigation showed the patch for *H-1457* is
>> >> > >> incorrect.
>> >> > >> I've attached a patch fixing this issue.
>> >> > >> Thanks Evgueni Brevnov for preparing this patch. After  
>> applying
>> >> these
>> >> >
>> >> > >> changes the issue disappeared.
>> >> > >>
>> >> > >> Geir, could you please look at this patch and apply it if
 
>> there
>> >> > >> are no
>> >> > >> objections?
>> >> > >>
>> >> > >> Thanks in advance,
>> >> > >> Vladimir.
>> >> > >>
>> >> > >>  On 9/24/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
>> >> > >> >
>> >> > >> > Ok, I'm not as worried - I went back a few days to  
>> r447025 and
>> >> > >> still
>> >> > >> > have the problem, so it's not from this morning.  I 

>> guess this
>> has
>> >> > >> > been masked all along by the logger problem.  Noted in
JIRA
>> >> > >> HARMONY-1560
>> >> > >> >
>> >> > >> > geir
>> >> > >> >
>> >> > >> > On Sep 23, 2006, at 11:04 AM, Geir Magnusson Jr. wrote:
>> >> > >> >
>> >> > >> > > This is completely my fault.
>> >> > >> > >
>> >> > >> > > The latest round of patches, while I dutifully do
 
>> smoke, c-
>> >> > >> unit and
>> >> > >> > > kernel tests for each patch, I didn't do any app
testing.
>> >> > >> > >
>> >> > >> > > I tried to run ActiveMQ, and it breaks with an asset
in
>> >> > >> > > object_handles.cpp : 99
>> >> > >> > >
>> >> > >> > > I'm going to back out the two GC patches I applied
and  
>> hope
>> >> > >> for the
>> >> > >> > > best.
>> >> > >> > >
>> >> > >> > > geir
>> >> > >> > >
>> >> > >> > >
>> >> > >> > >
>> >> > >>
>> >>  
>> ---------------------------------------------------------------------
>> >> > >> > > Terms of use :
>> http://incubator.apache.org/harmony/mailing.html
>> >> > >> > > To unsubscribe, e-mail: harmony-dev-
>> >> > >> unsubscribe@incubator.apache.org
>> >> > >> > > For additional commands, e-mail: harmony-dev-
>> >> > >> help@incubator.apache.org
>> >> > >> > >
>> >> > >> >
>> >> > >> >
>> >> > >> >
>> >> > >>
>> >>  
>> ---------------------------------------------------------------------
>> >> >
>> >> > >> > Terms of use : http://incubator.apache.org/harmony/ 
>> mailing.html
>> >> > >> > To unsubscribe, e-mail: harmony-dev-
>> >> > >> unsubscribe@incubator.apache.org
>> >> > >> > For additional commands, e-mail: harmony-dev-
>> >> > >> help@incubator.apache.org
>> >> > >> >
>> >> > >> >
>> >> > >>
>> >> > >>
>> >> >
>> >> >
>> >> >  
>> ---------------------------------------------------------------------
>> >> > Terms of use : http://incubator.apache.org/harmony/mailing.html
>> >> > To unsubscribe, e-mail: harmony-dev- 
>> unsubscribe@incubator.apache.org
>> >> > For additional commands, e-mail:
>> harmony-dev-help@incubator.apache.org
>> >> >
>> >> >
>> >>
>> >
>>
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev- 
>> help@incubator.apache.org
>>
>>


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message