harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geir Magnusson Jr." <g...@pobox.com>
Subject Re: [classlib][logging] In applying the LogManager patch...
Date Sat, 23 Sep 2006 13:12:56 GMT
+1

On Sep 23, 2006, at 8:50 AM, Alexey Varlamov wrote:

> Can't we muffle it for good?
>
> 2006/9/23, Richard Liang <richard.liangyx@gmail.com>:
>> On 9/23/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
>> > ... as suggested by Nikolay, I did run the tests
>> >
>> >    $ cd modules/logging
>> >    $ ant test
>> >
>> > and it was endless stacktraces, both before and after I made the
>> > modification.
>> >
>> > How do I know if I broke anything?  I'm going to go forward with  
>> the
>> > patch as I don't see any harm, since Logger.global is supposed  
>> to be
>> > set via getLogger("global") anyway, so subsequent settings  
>> shouldn't
>> > harm.
>> >
>>
>> I got the same stacktraces, and it said "BUILD SUCCESSFUL" in the  
>> end.
>> ;-)  After a quick looking through the test (SocketHandlerTest), I
>> found that some tests try to verify some expected exception, in the
>> mean while the exceptions are delegated to ErrorManager which reports
>> the exception to System.err.
>>
>> Running the test on RI, we will also see some error messages (not  
>> stacktraces)
>>
>> I guess you broke nothing ;-)
>>
>> Best regards,
>> Richard
>>
>> > geir
>> >
>> >
>> >  
>> ---------------------------------------------------------------------
>> > Terms of use : http://incubator.apache.org/harmony/mailing.html
>> > To unsubscribe, e-mail: harmony-dev- 
>> unsubscribe@incubator.apache.org
>> > For additional commands, e-mail: harmony-dev- 
>> help@incubator.apache.org
>> >
>> >
>>
>>
>> --
>> Richard Liang
>> China Development Lab, IBM
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev- 
>> help@incubator.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>


---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message