harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Denis Kishenko" <dkishe...@gmail.com>
Subject Re: [jira] Is it comfortable for committers when source and test patches are packed in the single diff file?
Date Tue, 26 Sep 2006 14:23:14 GMT
Geir, thanks for answer.

As I understand committers don't run tests from issue's descriptions?

2006/9/26, Geir Magnusson Jr. <geir@pobox.com>:
> I really, really like two patches as we discussed on a different thread.
>
> That way, I can apply the test patch, show the bug, apply the source
> patch, show it's gone (and then screw up and not commit all the code
> in the patch ;)
>
> Tim was neutral, but didn't care, so there's no opposition to asking
> for two.
>
> geir
>
> On Sep 26, 2006, at 9:29 AM, Denis Kishenko wrote:
>
> > Sometime I make two different diff files (source and test patches),
> > sometime I make the single one. Does it make sense for committers?
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>


-- 
Denis M. Kishenko
Intel Middleware Products Division

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org


Mime
View raw message